-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Defer generic awaited type #35284
Closed
Closed
Defer generic awaited type #35284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jablko
force-pushed
the
patch-26
branch
5 times, most recently
from
November 28, 2019 14:51
3e596bb
to
8145dda
Compare
jablko
force-pushed
the
patch-26
branch
3 times, most recently
from
January 25, 2020 20:23
b0cb02e
to
b96a504
Compare
@typescript-bot test this |
The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master. |
jablko
force-pushed
the
patch-26
branch
2 times, most recently
from
February 3, 2020 15:28
4dc37b5
to
e78a9aa
Compare
jablko
force-pushed
the
patch-26
branch
4 times, most recently
from
February 10, 2020 20:01
866166b
to
fb42ba3
Compare
jablko
force-pushed
the
patch-26
branch
3 times, most recently
from
February 12, 2020 21:42
65878c6
to
9a424b4
Compare
This was superseded by #45350 |
The TypeScript team hasn't accepted the linked issue #27711. If you can get it accepted, this PR will have a better chance of being reviewed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After
getAwaitedType()
returns the awaited type if it's known, orAwaited<T>
if it's generic.Fixes #27711
This proposal excludes non-A+ promises, which has the benefit of not requiring a recursive solution or a new kind of type, since an A+ promise can't resolve to another promise.
@typescript-bot test this
@typescript-bot run dt
@typescript-bot user test this