Type comparison when conditional type is target #35741
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jablko
force-pushed
the
patch-33
branch
3 times, most recently
from
d1c3ce2 to
f67c607
Compare
jablko
force-pushed
the
patch-33
branch
5 times, most recently
from
e381a49 to
9fb32ca
Compare
jablko
force-pushed
the
patch-33
branch
5 times, most recently
from
d7ef233 to
fca56ca
Compare
|
@jablko with all the other conditional type stuff merged, what parts of this do we still possibly need? |
|
To help with PR housekeeping, I'm going to close this PR since it's pretty old now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #30639 and #27932 (and #27589) that fixes #23132, as well as #26933. The implementation is analogous to #30769.
Fixes #23132
Fixes #25413
Fixes #26933
Fixes #29505
Fixes #29662