Reuse program structure #3616
Reuse program structure #3616
Conversation
…ts/references, remove module resolution from the checker
…dule kind differs in old and new programs, move setting of resolvedModules cache to the program, added tests
| @@ -5634,7 +5634,6 @@ namespace ts { | |||
| // will immediately bail out of walking any subtrees when we can see that their parents | |||
| // are already correct. | |||
| let result = Parser.parseSourceFile(sourceFile.fileName, newText, sourceFile.languageVersion, syntaxCursor, /* setParentNode */ true) | |||
|
|
|||
There was a problem hiding this comment.
unnecessary change, will remove it from the PR
|
|
||
| // if old program was provided by has different target module kind - assume that it cannot be reused | ||
| // different module kind can lead to different way of resolving modules | ||
| if (oldProgram && oldProgram.getCompilerOptions().module !== options.module) { |
There was a problem hiding this comment.
why not move this to tryReuseStructureFromOldProgram and just return false if this true.
There was a problem hiding this comment.
because in case if structure cannot be reused we still want to utilize previous resolutions, see processImports. However if old version of the program targeted different module kind - then resolutions should not be shared (not true currently but will be true after we incorporate different module resolution strategies). Presence or absence of old program acts as a marker if it can be reused
There was a problem hiding this comment.
also noResolve can not change between the two.
There was a problem hiding this comment.
if you want to be conservative and check the whole compilerOptions properties i am fine with that.
|
We should also put this in tsc.ts in the |
| @@ -2471,6 +2472,8 @@ namespace ts { | |||
| let newSettings = hostCache.compilationSettings(); | |||
| let changesInCompilationSettingsAffectSyntax = oldSettings && oldSettings.target !== newSettings.target; | |||
|
|
|||
| let reusableOldProgram = changesInCompilationSettingsAffectSyntax ? undefined : program; | |||
There was a problem hiding this comment.
we can move the target check to create program right?
|
👍 |
| if (!skipDefaultLib) { | ||
| processRootFile(host.getDefaultLibFileName(options), /*isDefaultLib:*/ true); | ||
|
|
||
| if (oldProgram) { |
There was a problem hiding this comment.
Just add an explanatory comment. Something to give hte intuition for why you are checking these specific options, and the types of options you'd put here in the future.
|
this change moved to #4154 |
|
@vladima can we close this now |
|
subsumed by #4154 |
Currently on every edit
createProgramrevisits all source files in order to discover all dependencies that are absent in root files and reconstruct the proper sequence of files. This is right thing to do however usually most of edits don't modify imports and tripleslash references so set and order of files remains the same. This PR tries to detect such cases: if edit does not affect the structure of the program then we'll just reuse nonchanged files from the old program keeping the same order.