feat(36048): Apply uncalled function checks to ternaries #36402
Conversation
|
@weswigham and @DanielRosenwasser are probably the best reviewers for this. |
There was a problem hiding this comment.
Looks like a striaghtforward generalization of the if machinery to ternaries to me~
The only thing I could add is that it's maybe also extendable to && (and ?? assuming we don't already issue an error there), so we could also probably check binary expressions in this way.
|
@typescript-bot test this |
|
Heya @DanielRosenwasser, I've started to run the parallelized community code test suite on this PR at 94dbe2f. You can monitor the build here. It should now contribute to this PR's status checks. |
|
Heya @DanielRosenwasser, I've started to run the extended test suite on this PR at 94dbe2f. You can monitor the build here. It should now contribute to this PR's status checks. |
|
With 3.8 leaving beta at end of week, let's hold this until 3.9. |
|
The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master. |
|
The following lines cause the error TypeScript/src/server/project.ts Line 1382 in fa3173f TypeScript/src/server/project.ts Line 1312 in fa3173f Is it the right condition in this case? |
|
Yes, those errors are correct, and they should be fixed before merging this PR. I asked @uniqueiniquity to investigate. |
|
Fix is #36885, thanks @uniqueiniquity for figuring it out. |
|
OK, @a-tarasyuk can you merge from master and I'll re-run the user tests to make sure they're still good. |
|
@typescript-bot test this |
|
The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master. |
|
user and RWC tests look clean |
Fixes #36048