Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Response.performanceData public #36621

Merged
merged 1 commit into from
Feb 5, 2020
Merged

Make Response.performanceData public #36621

merged 1 commit into from
Feb 5, 2020

Conversation

amcasey
Copy link
Member

@amcasey amcasey commented Feb 5, 2020

Fixes #36589

@typescript-bot
Copy link
Collaborator

Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping @sheetalkamat, @amcasey, @mjbvz, @minestarks for you. Feel free to loop in other consumers/maintainers if necessary

@amcasey amcasey requested a review from RyanCavanaugh February 5, 2020 01:22
@amcasey
Copy link
Member Author

amcasey commented Feb 5, 2020

Manual port of #36595.

@amcasey amcasey merged commit fb86896 into microsoft:release-3.8 Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sheetalkamat sheetalkamat sheetalkamat approved these changes

@RyanCavanaugh RyanCavanaugh Awaiting requested review from RyanCavanaugh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amcasey @typescript-bot @sheetalkamat