Skip to content

Add property URL in Window interface #3741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add property URL in Window interface #3741

wants to merge 1 commit into from

Conversation

xtuc
Copy link

@xtuc xtuc commented Jul 4, 2015

Fix error TS2339: Property 'URL' does not exist on type 'Window'.

@msftclas
Copy link

msftclas commented Jul 4, 2015

Hi @xtuc, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

@DanielRosenwasser
Copy link
Member

Hey @xtuc thanks for the PR. A few things to note.

  1. We don't change lib.d.ts in bin. For anything in the default library, the definition is in one of the files in src/lib. Anything in bin is our output following a build step.
  2. I think the file is in dom.generated.d.ts, meaning it's not to be manually changed, though I could be wrong.

@mhegazy and @zhengbli might have some useful input on this.

Additionally, I notice that URL is actually a constructor function. I think the URL interface needs to be amended.

@xtuc
Copy link
Author

xtuc commented Jul 4, 2015

Ok, sorry I did not notice. I'll let you make the necesary changes because I do not know enough about the language.

@mhegazy
Copy link
Contributor

mhegazy commented Jul 6, 2015

@zhengbli can you take a look.

@mhegazy
Copy link
Contributor

mhegazy commented Jul 6, 2015

We need an issue to track this.

@xtuc
Copy link
Author

xtuc commented Jul 6, 2015

I created the issue: #3753

@xtuc xtuc closed this Jul 6, 2015
@mhegazy
Copy link
Contributor

mhegazy commented Jul 6, 2015

thanks!

@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants