Make skipLibCheck: true the default in --init #37808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheetalkamat
reviewed
Apr 6, 2020
| @@ -1115,7 +1115,8 @@ namespace ts { | |||
| target: ScriptTarget.ES5, | |||
| strict: true, | |||
| esModuleInterop: true, | |||
| forceConsistentCasingInFileNames: true | |||
| forceConsistentCasingInFileNames: true, | |||
| skipLibCheck: true | |||
There was a problem hiding this comment.
From the design meeting::
Ask is for skipLibCheck to be included in tsc --init, not that it's turned on.
There was a problem hiding this comment.
Yeah I agree - it looks like that. I think the design notes were the first part of the discussion - the JSON dump we worked on included it as true
RyanCavanaugh
approved these changes
Apr 7, 2020
4 tasks
9 tasks
This was referenced Aug 25, 2020
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37361 - we don't need "pretty" in there IMO, this brings the output of
--initin line with @RyanCavanaugh's comment from our design meeting - #37389