Infer extracted local variable name from property name #37902
Conversation
| @@ -1009,7 +1009,9 @@ namespace ts.refactor.extractSymbol { | |||
|
|
|||
| // Make a unique name for the extracted variable | |||
| const file = scope.getSourceFile(); | |||
| const localNameText = getUniqueName(isClassLike(scope) ? "newProperty" : "newLocal", file); | |||
| const localNameText = isPropertyAccessExpression(node) && !isClassLike(scope) && !checker.resolveName(node.name.text, node, SymbolFlags.Value, /*excludeGlobals*/ false) && !isPrivateIdentifier(node.name) && !isKeyword(node.name.originalKeywordKind!) | |||
There was a problem hiding this comment.
I know that this line is long… 😂
I did not extract it into a function as my initial goal was to minimize the amount of structural change required.
…but to pave a way for more inference to take place, I did some refactoring and extract them to getLocalNameText function. If these diffs look good, I can cherry pick them into this PR.
…and with the above refactoring, I was able to make it also infer local variable name by the expression’s type (diff). If this sounds like a good idea, I can open an another issue and submit that as another PR. (I prefer to limit the scope of this PR to just PropertyAccess, but if you prefer I can put them into this PR as well.)
Example of inferring variable name based on expression’s type (not included in this PR)
|
@minestarks @jessetrinity same on this refactoring PR |
sandersn
requested review from
gabritto and
jakebailey
and removed request for
minestarks and
jessetrinity
|
LGTM |
Fixes #37898
This PR makes TypeScript infer
newLocalname from property name when performing an "Extract to constant in enclosing scope" refactoring on aPropertyAccessExpression.