Skip to content

fix(37825): js extended class autocomplete includes extender's private fields #37906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2020
Merged

fix(37825): js extended class autocomplete includes extender's private fields #37906

merged 1 commit into from
Apr 22, 2020

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #37825

@sandersn sandersn requested review from orta and rbuckton April 16, 2020 15:18
@sandersn sandersn added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Apr 16, 2020
@orta
Copy link
Contributor

orta commented Apr 17, 2020

Yep, great, this looks good to me, and the tests are 👍

orta
orta approved these changes Apr 17, 2020
View reviewed changes
Copy link
Contributor

@orta orta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll give Ron a chance to check it out till monday and merge

@orta
Copy link
Contributor

orta commented Apr 22, 2020

Sheetal's green is definitely good enough for me 👍

@orta orta merged commit d201691 into microsoft:master Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orta orta orta approved these changes

@sheetalkamat sheetalkamat sheetalkamat approved these changes

@rbuckton rbuckton Awaiting requested review from rbuckton

Assignees

@orta orta

Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

js extended class autocomplete includes extender's private fields
4 participants
@a-tarasyuk @orta @sheetalkamat @sandersn