Dont look for properties of Object and Function type when looking to resolve named import from module with `export=` #37964

sheetalkamat · 2020-04-14T20:02:05Z

sheetalkamat · 2020-04-14T20:04:08Z

typescript-bot · 2020-04-14T20:04:12Z

Heya @sheetalkamat, I've started to run the extended test suite on this PR at 16b4153. You can monitor the build here.

sheetalkamat · 2020-04-14T20:04:47Z

@typescript-bot user test this

typescript-bot · 2020-04-14T20:04:49Z

Heya @sheetalkamat, I've started to run the parallelized community code test suite on this PR at 16b4153. You can monitor the build here.

sheetalkamat · 2020-04-14T20:05:05Z

@typescript-bot run dt

typescript-bot · 2020-04-14T20:05:07Z

Heya @sheetalkamat, I've started to run the parallelized Definitely Typed test suite on this PR at 16b4153. You can monitor the build here.

…ort=` type to be resolved by named imports Fixes #37165

sheetalkamat · 2020-04-24T19:14:12Z

@typescript-bot test this

typescript-bot · 2020-04-24T19:14:17Z

Heya @sheetalkamat, I've started to run the extended test suite on this PR at 5af482c. You can monitor the build here.

sheetalkamat · 2020-04-24T22:27:11Z

@typescript-bot run dt
@typescript-bot test this
@typescript-bot user test this

typescript-bot · 2020-04-24T22:27:18Z

Heya @sheetalkamat, I've started to run the parallelized community code test suite on this PR at 5af482c. You can monitor the build here.

typescript-bot · 2020-04-24T22:27:18Z

Heya @sheetalkamat, I've started to run the parallelized Definitely Typed test suite on this PR at 5af482c. You can monitor the build here.

typescript-bot · 2020-04-24T22:27:18Z

Heya @sheetalkamat, I've started to run the extended test suite on this PR at 5af482c. You can monitor the build here.

src/compiler/checker.ts

weswigham · 2020-05-05T20:13:46Z

src/compiler/checker.ts

@@ -2586,7 +2586,7 @@ namespace ts {
                    let symbolFromVariable: Symbol | undefined;
                    // First check if module was specified with "export=". If so, get the member from the resolved type
                    if (moduleSymbol && moduleSymbol.exports && moduleSymbol.exports.get(InternalSymbolName.ExportEquals)) {
-                        symbolFromVariable = getPropertyOfType(getTypeOfSymbol(targetSymbol), name.escapedText);
+                        symbolFromVariable = getPropertyOfType(getTypeOfSymbol(targetSymbol), name.escapedText, /*skipObjectFunctionPropertyAugment*/ true);


Actually, rather than threading through this flag, and worrying about the safety of caching it and have two differently calculated symbols for a property lookup, couldn't we

Initialize globalFunctionType and globalObjectType each to a unique empty type (which should naturally cause property lookups that ultimately may have depended on them to fail during global initialization).

Check if symbolFromVariable.parent here is globalObjectType or globalFunctionType and, if so, discard the result? (to ensure consistency with the initialization phase)

We want this to happen irrespective of augmenting that means any time we import the properties from object/function should be error so this might not happen at augmentation time.

Will there be some kind of edge case where in valid scenario return globalfunctionType property symbol. That is what if getTypeOfSymbol(targetSymbol) is globalFunctionType or globalObjectType

…entation

sheetalkamat · 2020-07-25T00:12:09Z

@typescript-bot run dt
@typescript-bot test this
@typescript-bot user test this

typescript-bot · 2020-07-25T00:12:12Z

Heya @sheetalkamat, I've started to run the parallelized community code test suite on this PR at a252ef9. You can monitor the build here.

typescript-bot · 2020-07-25T00:12:12Z

Heya @sheetalkamat, I've started to run the extended test suite on this PR at a252ef9. You can monitor the build here.

typescript-bot · 2020-07-25T00:12:12Z

Heya @sheetalkamat, I've started to run the parallelized Definitely Typed test suite on this PR at a252ef9. You can monitor the build here.

typescript-bot · 2020-07-25T00:48:11Z

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

sheetalkamat · 2020-08-03T20:12:15Z

@typescript-bot user test this

typescript-bot · 2020-08-03T20:12:18Z

Heya @sheetalkamat, I've started to run the parallelized community code test suite on this PR at a252ef9. You can monitor the build here.

sheetalkamat · 2020-08-03T20:15:30Z

@typescript-bot run dt
@typescript-bot test this

typescript-bot · 2020-08-03T20:15:33Z

Heya @sheetalkamat, I've started to run the parallelized Definitely Typed test suite on this PR at a252ef9. You can monitor the build here.

typescript-bot · 2020-08-03T20:15:33Z

Heya @sheetalkamat, I've started to run the extended test suite on this PR at a252ef9. You can monitor the build here.

sheetalkamat · 2020-08-03T21:07:07Z

All the tests passed.

sandersn · 2020-10-20T22:39:01Z

@weswigham looking at your last review, it looks like @sheetalkamat addressed your questions. Is this ready to merge once 4.1 RC is out?

src/compiler/checker.ts

sheetalkamat · 2020-10-21T21:29:32Z

Will wait for master to become 4.2 before merging this one.

sheetalkamat requested review from DanielRosenwasser, weswigham and ahejlsberg April 14, 2020 20:02

typescript-bot assigned sheetalkamat Apr 14, 2020

typescript-bot added the Author: Team label Apr 14, 2020

sheetalkamat requested a review from RyanCavanaugh April 14, 2020 20:02

sheetalkamat mentioned this pull request Apr 21, 2020

Cannot read property 'flags' of undefined #37165

Closed

sheetalkamat added 2 commits April 24, 2020 12:07

Add tests

8c9128a

Dont look at object or function type when looking for members of `exp…

5af482c

…ort=` type to be resolved by named imports Fixes #37165

DanielRosenwasser mentioned this pull request Apr 24, 2020

Design Meeting Notes, 4/24/2020 #38168

Closed

sheetalkamat force-pushed the importMerge branch from 16b4153 to 5af482c Compare April 24, 2020 19:13

sandersn assigned weswigham and unassigned sheetalkamat May 5, 2020

sandersn added the For Milestone Bug PRs that fix a bug with a specific milestone label May 5, 2020

weswigham requested changes May 5, 2020

View reviewed changes

sheetalkamat mentioned this pull request May 20, 2020

fix(37165): Cannot read property 'flags' of undefined #37228

Closed

sheetalkamat added 2 commits July 24, 2020 16:58

Merge branch 'master' into importMerge

fd9c2ea

Create separate cache when skipping function and object property augm…

a252ef9

…entation

typescript-bot mentioned this pull request Jul 25, 2020

🤖 User test baselines have changed for importMerge typescript-bot/TypeScript#65

Open

weswigham reviewed Oct 21, 2020

View reviewed changes

src/compiler/checker.ts Outdated Show resolved Hide resolved

Lookup in both cache if not skipObjectFunctionPropertyAugment

5a964bd

sheetalkamat force-pushed the importMerge branch from a9e4980 to 5a964bd Compare October 21, 2020 20:11

weswigham approved these changes Oct 21, 2020

View reviewed changes

Merge branch 'master' into importMerge

55ed718

sheetalkamat merged commit 9c60d5a into master Nov 3, 2020

sheetalkamat deleted the importMerge branch November 3, 2020 20:22

andrewbranch mentioned this pull request Feb 2, 2023

Fix crash when looking for __esModule during symbol table merging #52554

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dont look for properties of Object and Function type when looking to resolve named import from module with `export=` #37964

Dont look for properties of Object and Function type when looking to resolve named import from module with `export=` #37964

sheetalkamat commented Apr 14, 2020

sheetalkamat commented Apr 14, 2020

typescript-bot commented Apr 14, 2020 •

edited

Loading

sheetalkamat commented Apr 14, 2020

typescript-bot commented Apr 14, 2020 •

edited

Loading

sheetalkamat commented Apr 14, 2020

typescript-bot commented Apr 14, 2020 •

edited

Loading

sheetalkamat commented Apr 24, 2020

typescript-bot commented Apr 24, 2020 •

edited

Loading

sheetalkamat commented Apr 24, 2020

typescript-bot commented Apr 24, 2020 •

edited

Loading

typescript-bot commented Apr 24, 2020 •

edited

Loading

typescript-bot commented Apr 24, 2020 •

edited

Loading

weswigham May 5, 2020 •

edited

Loading

sheetalkamat Jul 25, 2020 •

edited

Loading

sheetalkamat commented Jul 25, 2020

typescript-bot commented Jul 25, 2020 •

edited

Loading

typescript-bot commented Jul 25, 2020 •

edited

Loading

typescript-bot commented Jul 25, 2020 •

edited

Loading

typescript-bot commented Jul 25, 2020

sheetalkamat commented Aug 3, 2020

typescript-bot commented Aug 3, 2020 •

edited

Loading

sheetalkamat commented Aug 3, 2020

typescript-bot commented Aug 3, 2020 •

edited

Loading

typescript-bot commented Aug 3, 2020 •

edited

Loading

sheetalkamat commented Aug 3, 2020

sandersn commented Oct 20, 2020

sheetalkamat commented Oct 21, 2020

Dont look for properties of Object and Function type when looking to resolve named import from module with export= #37964

Dont look for properties of Object and Function type when looking to resolve named import from module with export= #37964

Conversation

sheetalkamat commented Apr 14, 2020

sheetalkamat commented Apr 14, 2020

typescript-bot commented Apr 14, 2020 • edited Loading

sheetalkamat commented Apr 14, 2020

typescript-bot commented Apr 14, 2020 • edited Loading

sheetalkamat commented Apr 14, 2020

typescript-bot commented Apr 14, 2020 • edited Loading

sheetalkamat commented Apr 24, 2020

typescript-bot commented Apr 24, 2020 • edited Loading

sheetalkamat commented Apr 24, 2020

typescript-bot commented Apr 24, 2020 • edited Loading

typescript-bot commented Apr 24, 2020 • edited Loading

typescript-bot commented Apr 24, 2020 • edited Loading

weswigham May 5, 2020 • edited Loading

Choose a reason for hiding this comment

sheetalkamat Jul 25, 2020 • edited Loading

Choose a reason for hiding this comment

sheetalkamat commented Jul 25, 2020

typescript-bot commented Jul 25, 2020 • edited Loading

typescript-bot commented Jul 25, 2020 • edited Loading

typescript-bot commented Jul 25, 2020 • edited Loading

typescript-bot commented Jul 25, 2020

sheetalkamat commented Aug 3, 2020

typescript-bot commented Aug 3, 2020 • edited Loading

sheetalkamat commented Aug 3, 2020

typescript-bot commented Aug 3, 2020 • edited Loading

typescript-bot commented Aug 3, 2020 • edited Loading

sheetalkamat commented Aug 3, 2020

sandersn commented Oct 20, 2020

sheetalkamat commented Oct 21, 2020

Dont look for properties of Object and Function type when looking to resolve named import from module with `export=` #37964

Dont look for properties of Object and Function type when looking to resolve named import from module with `export=` #37964

typescript-bot commented Apr 14, 2020 •

edited

Loading

typescript-bot commented Apr 14, 2020 •

edited

Loading

typescript-bot commented Apr 14, 2020 •

edited

Loading

typescript-bot commented Apr 24, 2020 •

edited

Loading

typescript-bot commented Apr 24, 2020 •

edited

Loading

typescript-bot commented Apr 24, 2020 •

edited

Loading

typescript-bot commented Apr 24, 2020 •

edited

Loading

weswigham May 5, 2020 •

edited

Loading

sheetalkamat Jul 25, 2020 •

edited

Loading

typescript-bot commented Jul 25, 2020 •

edited

Loading

typescript-bot commented Jul 25, 2020 •

edited

Loading

typescript-bot commented Jul 25, 2020 •

edited

Loading

typescript-bot commented Aug 3, 2020 •

edited

Loading

typescript-bot commented Aug 3, 2020 •

edited

Loading

typescript-bot commented Aug 3, 2020 •

edited

Loading