Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Revert #37106" #38216

Closed
wants to merge 1 commit into from
Closed

Revert "Revert #37106" #38216

wants to merge 1 commit into from

Conversation

DanielRosenwasser
Copy link
Member

Reverts #38172

@DanielRosenwasser
Revert "Revert #37106 (#38172)"
255b65a 
This reverts commit 84c83da.
@DanielRosenwasser
Copy link
Member Author

Chatted with @sandersn - it sounds like per discussion in #38168, we need some special exemption for globalThis. We can merge and then have a follow-up issue, or we can have someone build on this branch.

@sandersn sandersn added the For Milestone Bug PRs that fix a bug with a specific milestone label May 12, 2020
@sandersn sandersn self-assigned this May 12, 2020
@weswigham
Copy link
Member

@sandersn is this waiting on work form you or @DanielRosenwasser ? I don't think there's much for me to review here right now (that I didn't already look over once when it was first merged before being reverted for want of less breakiness).

@DanielRosenwasser DanielRosenwasser deleted the revert-38172-revert37106 branch August 27, 2020 22:11
@typescript-bot typescript-bot added For Uncommitted Bug PR for untriaged, rejected, closed or missing bug and removed For Milestone Bug PRs that fix a bug with a specific milestone labels Aug 27, 2020
@DanielRosenwasser
Copy link
Member Author

Might as well add a new PR, but worth reinvestigating if @sandersn remembers anything special that we need to re-introduce

@weswigham
Copy link
Member

I think #39637 superceded this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weswigham weswigham Awaiting requested review from weswigham

@RyanCavanaugh RyanCavanaugh Awaiting requested review from RyanCavanaugh

@sandersn sandersn Awaiting requested review from sandersn

Assignees

@sandersn sandersn

Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DanielRosenwasser @weswigham @sandersn @typescript-bot