Syntax only server creates inferred project with all the open files w… #38561

sheetalkamat · 2020-05-13T23:12:19Z

…ith noResolve and can handle semantic operations

Fixes #

…ith noResolve and can handle semantic operations

sheetalkamat · 2020-05-13T23:12:30Z

typescript-bot · 2020-05-13T23:12:33Z

Heya @sheetalkamat, I've started to run the tarball bundle task on this PR at 5726838. You can monitor the build here.

sheetalkamat · 2020-05-13T23:57:32Z

@typescript-bot pack this

typescript-bot · 2020-05-13T23:57:36Z

Heya @sheetalkamat, I've started to run the tarball bundle task on this PR at 90d8a96. You can monitor the build here.

typescript-bot · 2020-05-14T00:04:46Z

Hey @sheetalkamat, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/73860/artifacts?artifactName=tgz&fileId=2BC1D5FE49C2AD5CCA135D57CEE4CA308A5E08ADDD7B5A264EDC56EE6D487BE002&fileName=/typescript-4.0.0-insiders.20200514.tgz"
    }
}

and then running npm install.

There is also a playground for this build.

sheetalkamat · 2020-05-14T17:53:58Z

@mjbvz @minestarks @uniqueiniquity @amcasey @DanielRosenwasser @RyanCavanaugh
#38561 (comment) is build where syntaxOnly server can accept semantic commands.. ( i havent added any custom changes for any semantic commands nor have i limited any semantic operations as part of this prototype)

#38564 is PR that is on top of this and makes normal tsserver behave like syntaxOnly (one with semantic operations allowed)

amcasey · 2020-05-14T20:12:01Z

I'll be interested to see what this does to startup perf on the syntax server. Looks pretty cool though.

amcasey · 2020-05-22T20:34:22Z

I've run into a pretty big issue on the VS side: semantic operations tend to be triggered for Roslyn Documents and those don't exist until the project is loaded. So I see operations during project load in already open documents, but not in the newly opened document (i.e. the one that triggered the project load). Obviously, this has nothing to do with the tsserver change.

DanielRosenwasser · 2020-06-09T17:32:35Z

@typescript-bot pack this

typescript-bot · 2020-06-09T17:32:53Z

Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at 90d8a96. You can monitor the build here.

typescript-bot · 2020-06-09T17:40:17Z

Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/75966/artifacts?artifactName=tgz&fileId=BB849547A1DF11A54E5245D89DF5DAFE50EAC3E3C08A813981103A387395A0B802&fileName=/typescript-4.0.0-insiders.20200609.tgz"
    }
}

and then running npm install.

There is also a playground for this build.

DanielRosenwasser · 2020-06-09T18:14:06Z

I'm not able to see things working better with

the latest VS Code Insiders with commit microsoft/vscode@480c98f
"typescript.tsserver.useSeparateSyntaxServer": "dynamic",
using this build: Syntax only server creates inferred project with all the open files w… #38561 (comment)

DanielRosenwasser · 2020-06-11T19:11:08Z

@typescript-bot pack this

typescript-bot · 2020-06-11T19:11:24Z

Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at 90d8a96. You can monitor the build here.

typescript-bot · 2020-06-11T19:19:08Z

Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/76193/artifacts?artifactName=tgz&fileId=0AD85EA4EF3D7253C964378CA736CCDB891DD80E981648EE08731F97511241AD02&fileName=/typescript-4.0.0-insiders.20200611.tgz"
    }
}

and then running npm install.

There is also a playground for this build.

DanielRosenwasser · 2020-06-11T19:40:40Z

I'm finally trying this out with VS Code Insiders! Pretty cool! A couple of thoughts and ideas

From the editor side:

the startup time still isn't instantaneous for the syntax server, so I'm really never sure whether I can start editing reliably until I try quick info over and over. I think this is something we'll really need to provide a visual indication for before we make it broadly available.

From the TypeScript side:

I think cross-file go-to-definition was one of the key scenarios we'd like to get to users, so I think we should really try to get that to light up, either here or in a follow-up PR.
the fact that we show any when things aren't resolved in this mode is kind of confusing. For type display purposes, we might want to consider displaying the error type as something like a loading type.

@CyrusNajmabadi, how does Roslyn work when types haven't been resolved yet in things like quick info and signature help?

For example we have this signature

but CodeActionsState.State can't be resolved, so signature help looks like this:

CyrusNajmabadi · 2020-06-11T19:48:00Z

@CyrusNajmabadi, how does Roslyn work when types haven't been resolved yet in things like quick info and signature help?

We don't have that concept :)

sheetalkamat · 2020-06-13T00:07:19Z

src/server/session.ts

+        CommandNames.CompileOnSaveEmitFile,
+        CommandNames.CompilerOptionsDiagnosticsFull,
+        CommandNames.EncodedSemanticClassificationsFull,
+        CommandNames.SemanticDiagnosticsSync,


SyntacticDiagnosticsSync: This is somewhat project setting dependent ? Atleast at some point parsing errors use to be different based on target .. eg target determines what unicode is considered identifier start... So i am not sure if this should be enabled.. But if we do enable we i was wondering if GetErr should only do syntax checks and skip semantic and suggetion diagnostics on syntax server

Some questionable which i have disabled for now
Reload
ReloadProjects
PrepareCallHierarchy
ProvideCallHierarchyIncomingCalls
ProvideCallHierarchyOutgoingCalls

sheetalkamat · 2020-06-13T00:10:41Z

@typescript-bot pack this

typescript-bot · 2020-06-13T00:10:42Z

Heya @sheetalkamat, I've started to run the tarball bundle task on this PR at 89127a5. You can monitor the build here.

typescript-bot · 2020-06-13T00:17:05Z

Hey @sheetalkamat, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/76345/artifacts?artifactName=tgz&fileId=CD3C20B0D73291C13F028F1A072CA740FDD866AD700C026ACA443AFA3B0B0C3002&fileName=/typescript-4.0.0-insiders.20200613.tgz"
    }
}

and then running npm install.

There is also a playground for this build.

amcasey

Some comments, but LGTM

Gulpfile.js

src/server/session.ts

amcasey · 2020-06-16T00:51:04Z

src/services/services.ts

@@ -1171,6 +1171,26 @@ namespace ts {
        }
    }

+    const invalidOperationsOnSyntaxOnly: readonly (keyof LanguageService)[] = [


How does this relate to the list in session.ts? Do they need to stay in sync? Is one redundant?

amcasey · 2020-06-16T00:51:59Z

src/services/services.ts

+        if (syntaxOnly) {
+            invalidOperationsOnSyntaxOnly.forEach(key =>
+                ls[key] = (...args: any[]) => {
+                    throw new Error(`LanguageService Operation: ${key} not allowed on syntaxServer:: arguments::${JSON.stringify(args)}`);


As above, we probably don't need the arguments.

This reverts commit 90d8a96.

DanielRosenwasser · 2020-06-16T20:06:49Z

Speaking of logs- do editors log from the syntax server?

amcasey · 2020-06-16T20:13:54Z

VS logging is opt-in (via env var or regkey), but, yes, it applies to both.

VS Code only has a command to show the semantic log (AFAIK), but I'm pretty sure it enables both.

sheetalkamat · 2020-06-16T20:39:13Z

@mjbvz We definitely want users to be able to share the syntaxOnly server logs easily.

Syntax only server creates inferred project with all the open files w…

5726838

…ith noResolve and can handle semantic operations

typescript-bot assigned sheetalkamat May 13, 2020

typescript-bot added the Author: Team label May 13, 2020

sheetalkamat added 2 commits May 13, 2020 16:31

No Watching

ffe50a3

Disable tests

90d8a96

sheetalkamat mentioned this pull request May 14, 2020

Always syntax only #38564

Closed

dherman mentioned this pull request Jun 9, 2020

Support volta installing a tarball volta-cli/volta#427

Closed

DanielRosenwasser mentioned this pull request Jun 9, 2020

Support sending some commands to syntax TS Server while a project is loading microsoft/vscode#99643

Closed

DanielRosenwasser mentioned this pull request Jun 12, 2020

Partial Semantic Mode Meta-Issue #39035

Open

5 tasks

sheetalkamat added 3 commits June 12, 2020 14:43

Merge branch 'master' into syntaxAsSemanticServer

cb638d9

Add and fix tests

807c008

Only support selected commands

89127a5

sheetalkamat marked this pull request as ready for review June 13, 2020 00:06

sheetalkamat commented Jun 13, 2020

View reviewed changes

sheetalkamat requested review from amcasey, andrewbranch, DanielRosenwasser and RyanCavanaugh June 13, 2020 00:07

amcasey approved these changes Jun 16, 2020

View reviewed changes

sheetalkamat added 2 commits June 16, 2020 12:58

Revert "Disable tests"

3e1a3c2

This reverts commit 90d8a96.

Dont log request details for unsupported commands

901cfc3

sheetalkamat merged commit 25f6232 into master Jun 16, 2020

sheetalkamat deleted the syntaxAsSemanticServer branch June 16, 2020 20:39

github-actions bot mentioned this pull request Oct 4, 2022

[Korean] Fix weird expressions like '_제네릭_' microsoft/TypeScript-Website-Localizations#171

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Syntax only server creates inferred project with all the open files w… #38561

Syntax only server creates inferred project with all the open files w… #38561

sheetalkamat commented May 13, 2020

sheetalkamat commented May 13, 2020

typescript-bot commented May 13, 2020 •

edited

Loading

sheetalkamat commented May 13, 2020

typescript-bot commented May 13, 2020 •

edited

Loading

typescript-bot commented May 14, 2020 •

edited

Loading

sheetalkamat commented May 14, 2020

amcasey commented May 14, 2020

amcasey commented May 22, 2020

DanielRosenwasser commented Jun 9, 2020

typescript-bot commented Jun 9, 2020 •

edited

Loading

typescript-bot commented Jun 9, 2020 •

edited

Loading

DanielRosenwasser commented Jun 9, 2020 •

edited

Loading

DanielRosenwasser commented Jun 11, 2020

typescript-bot commented Jun 11, 2020 •

edited

Loading

typescript-bot commented Jun 11, 2020 •

edited

Loading

DanielRosenwasser commented Jun 11, 2020 •

edited

Loading

CyrusNajmabadi commented Jun 11, 2020

sheetalkamat Jun 13, 2020

sheetalkamat commented Jun 13, 2020

typescript-bot commented Jun 13, 2020 •

edited

Loading

typescript-bot commented Jun 13, 2020 •

edited

Loading

amcasey left a comment

amcasey Jun 16, 2020

amcasey Jun 16, 2020

DanielRosenwasser commented Jun 16, 2020

amcasey commented Jun 16, 2020

sheetalkamat commented Jun 16, 2020

Syntax only server creates inferred project with all the open files w… #38561

Syntax only server creates inferred project with all the open files w… #38561

Conversation

sheetalkamat commented May 13, 2020

sheetalkamat commented May 13, 2020

typescript-bot commented May 13, 2020 • edited Loading

sheetalkamat commented May 13, 2020

typescript-bot commented May 13, 2020 • edited Loading

typescript-bot commented May 14, 2020 • edited Loading

sheetalkamat commented May 14, 2020

amcasey commented May 14, 2020

amcasey commented May 22, 2020

DanielRosenwasser commented Jun 9, 2020

typescript-bot commented Jun 9, 2020 • edited Loading

typescript-bot commented Jun 9, 2020 • edited Loading

DanielRosenwasser commented Jun 9, 2020 • edited Loading

DanielRosenwasser commented Jun 11, 2020

typescript-bot commented Jun 11, 2020 • edited Loading

typescript-bot commented Jun 11, 2020 • edited Loading

DanielRosenwasser commented Jun 11, 2020 • edited Loading

CyrusNajmabadi commented Jun 11, 2020

sheetalkamat Jun 13, 2020

Choose a reason for hiding this comment

sheetalkamat commented Jun 13, 2020

typescript-bot commented Jun 13, 2020 • edited Loading

typescript-bot commented Jun 13, 2020 • edited Loading

amcasey left a comment

Choose a reason for hiding this comment

amcasey Jun 16, 2020

Choose a reason for hiding this comment

amcasey Jun 16, 2020

Choose a reason for hiding this comment

DanielRosenwasser commented Jun 16, 2020

amcasey commented Jun 16, 2020

sheetalkamat commented Jun 16, 2020

typescript-bot commented May 13, 2020 •

edited

Loading

typescript-bot commented May 13, 2020 •

edited

Loading

typescript-bot commented May 14, 2020 •

edited

Loading

typescript-bot commented Jun 9, 2020 •

edited

Loading

typescript-bot commented Jun 9, 2020 •

edited

Loading

DanielRosenwasser commented Jun 9, 2020 •

edited

Loading

typescript-bot commented Jun 11, 2020 •

edited

Loading

typescript-bot commented Jun 11, 2020 •

edited

Loading

DanielRosenwasser commented Jun 11, 2020 •

edited

Loading

typescript-bot commented Jun 13, 2020 •

edited

Loading

typescript-bot commented Jun 13, 2020 •

edited

Loading