Code fix for accidental calls to get-accessors

[jtbandes]

Backlog bug: #24554
This is a follow-up to #37800 which adds a code fix associated with the new error message.
cc @sandersn for review :)

The cleanest way I found to implement this was updating the parser to keep references to the open/close paren tokens. Unfortunately I wasn't able to make forEachChild handle these properly, (see commit history in this branch) so I just skip these nodes. Let me know if there's a better way!

 class Test24554 {
     get property(): number { return 1; }
 }
 function test24554(x: Test24554) {
-    return x.property();
+    return x.property;
 }
 function test_2(x: { y: Test24554 }) {
-    return x.y.property ( /* bye */ );
+    return x.y.property;
 }

[SmolinPavel]

🥇

[sandersn]

Looks good once the whitespace in diagnosticMessages.json is back to normal.

[sandersn]

looks like whitespace changed in this file. Can you undo that change please?

[jtbandes]

That seems like a recurring problem, at least for me. I fixed this merge conflict through the GitHub UI and this is what I got. Do you know why this might be happening? (Windows line endings for example?) I wonder if there's a way it can be resolved on master such that it stops happening.

In the meantime, I'll fix it on this branch shortly...

[sandersn]

What editor do you use? Do you have prettier or other formatting configured? The linux+emacs and macos+code people don't have this problem as far as I'm aware, although it does have Windows line endings.

[jtbandes]

Hm, I guess it's possible that the problem only happens in the GitHub merge UI. I didn't keep careful track of when it happened and when it didn't. Anyway, fixed now :)