Skip to content

fix(lib/es2015): Remove Reflect.enumerate(…) #38967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2020
Merged

fix(lib/es2015): Remove Reflect.enumerate(…) #38967

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/lib/es2015.iterable.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,10 +222,6 @@ interface PromiseConstructor {
race<T>(values: Iterable<T | PromiseLike<T>>): Promise<T>;
}

declare namespace Reflect {
function enumerate(target: object): IterableIterator<any>;
}

interface String {
/** Iterator */
[Symbol.iterator](): IterableIterator<string>;
Expand Down
1 change: 0 additions & 1 deletion src/lib/es2015.proxy.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ interface ProxyHandler<T extends object> {
set? (target: T, p: PropertyKey, value: any, receiver: any): boolean;
deleteProperty? (target: T, p: PropertyKey): boolean;
defineProperty? (target: T, p: PropertyKey, attributes: PropertyDescriptor): boolean;
enumerate? (target: T): PropertyKey[];
ownKeys? (target: T): PropertyKey[];
apply? (target: T, thisArg: any, argArray?: any): any;
construct? (target: T, argArray: any, newTarget?: any): object;
Expand Down
8 changes: 4 additions & 4 deletions tests/baselines/reference/mappedTypeRecursiveInference.types
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion tests/baselines/reference/modularizeLibrary_NoErrorDuplicateLibOptions1.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ var p = new Proxy(t, {});
// Using ES6 reflect
Reflect.isExtensible({});
>Reflect.isExtensible : Symbol(Reflect.isExtensible, Decl(lib.es2015.reflect.d.ts, --, --))
>Reflect : Symbol(Reflect, Decl(lib.es2015.iterable.d.ts, --, --), Decl(lib.es2015.reflect.d.ts, --, --))
>Reflect : Symbol(Reflect, Decl(lib.es2015.reflect.d.ts, --, --))
>isExtensible : Symbol(Reflect.isExtensible, Decl(lib.es2015.reflect.d.ts, --, --))

// Using Es6 regexp
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/modularizeLibrary_NoErrorDuplicateLibOptions2.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ var p = new Proxy(t, {});
// Using ES6 reflect
Reflect.isExtensible({});
>Reflect.isExtensible : Symbol(Reflect.isExtensible, Decl(lib.es2015.reflect.d.ts, --, --))
>Reflect : Symbol(Reflect, Decl(lib.es2015.iterable.d.ts, --, --), Decl(lib.es2015.reflect.d.ts, --, --))
>Reflect : Symbol(Reflect, Decl(lib.es2015.reflect.d.ts, --, --))
>isExtensible : Symbol(Reflect.isExtensible, Decl(lib.es2015.reflect.d.ts, --, --))

// Using Es6 regexp
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/modularizeLibrary_TargetES5UsingES6Lib.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ var p = new Proxy(t, {});
// Using ES6 reflect
Reflect.isExtensible({});
>Reflect.isExtensible : Symbol(Reflect.isExtensible, Decl(lib.es2015.reflect.d.ts, --, --))
>Reflect : Symbol(Reflect, Decl(lib.es2015.iterable.d.ts, --, --), Decl(lib.es2015.reflect.d.ts, --, --))
>Reflect : Symbol(Reflect, Decl(lib.es2015.reflect.d.ts, --, --))
>isExtensible : Symbol(Reflect.isExtensible, Decl(lib.es2015.reflect.d.ts, --, --))

// Using Es6 regexp
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/modularizeLibrary_TargetES6UsingES6Lib.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ var p = new Proxy(t, {});
// Using ES6 reflect
Reflect.isExtensible({});
>Reflect.isExtensible : Symbol(Reflect.isExtensible, Decl(lib.es2015.reflect.d.ts, --, --))
>Reflect : Symbol(Reflect, Decl(lib.es2015.iterable.d.ts, --, --), Decl(lib.es2015.reflect.d.ts, --, --))
>Reflect : Symbol(Reflect, Decl(lib.es2015.reflect.d.ts, --, --))
>isExtensible : Symbol(Reflect.isExtensible, Decl(lib.es2015.reflect.d.ts, --, --))

// Using Es6 regexp
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/modularizeLibrary_UsingES5LibAndES6FeatureLibs.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ var p = new Proxy(t, {});

Reflect.ownKeys({});
>Reflect.ownKeys : Symbol(Reflect.ownKeys, Decl(lib.es2015.reflect.d.ts, --, --))
>Reflect : Symbol(Reflect, Decl(lib.es2015.iterable.d.ts, --, --), Decl(lib.es2015.reflect.d.ts, --, --))
>Reflect : Symbol(Reflect, Decl(lib.es2015.reflect.d.ts, --, --))
>ownKeys : Symbol(Reflect.ownKeys, Decl(lib.es2015.reflect.d.ts, --, --))

function* idGen() {
Expand Down