Skip to content

Use combined node flags #39403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 15, 2020
Merged

Use combined node flags #39403

merged 2 commits into from
Jul 15, 2020

Conversation

Kingwl
Copy link
Contributor

@Kingwl Kingwl commented Jul 3, 2020

Fixes a part of #39374

@Kingwl
Copy link
Contributor Author

Kingwl commented Jul 8, 2020

@typescript-bot perf test.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jul 8, 2020 •
edited
Loading

Heya @Kingwl, I've started to run the perf test suite on this PR at 84bad5e. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@Kingwl
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..39403

Metric master 39403 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 343,892k (± 0.03%) 343,406k (± 0.01%) -486k (- 0.14%) 343,285k 343,570k
Parse Time 2.02s (± 0.35%) 2.02s (± 0.61%) +0.00s (+ 0.15%) 1.99s 2.05s
Bind Time 0.82s (± 0.49%) 0.83s (± 2.23%) +0.01s (+ 1.10%) 0.81s 0.90s
Check Time 4.76s (± 0.49%) 4.79s (± 0.36%) +0.03s (+ 0.65%) 4.74s 4.83s
Emit Time 5.20s (± 0.83%) 5.21s (± 0.52%) +0.01s (+ 0.17%) 5.16s 5.28s
Total Time 12.80s (± 0.52%) 12.85s (± 0.37%) +0.05s (+ 0.38%) 12.73s 12.92s
Monaco - node (v10.16.3, x64)
Memory used 339,107k (± 0.02%) 339,102k (± 0.03%) -5k (- 0.00%) 338,878k 339,375k
Parse Time 1.59s (± 0.42%) 1.59s (± 0.92%) -0.00s (- 0.25%) 1.55s 1.63s
Bind Time 0.71s (± 0.70%) 0.72s (± 0.51%) +0.00s (+ 0.14%) 0.71s 0.72s
Check Time 4.89s (± 0.80%) 4.93s (± 0.53%) +0.04s (+ 0.80%) 4.88s 4.98s
Emit Time 2.76s (± 0.55%) 2.76s (± 0.82%) +0.00s (+ 0.07%) 2.73s 2.83s
Total Time 9.96s (± 0.50%) 9.99s (± 0.41%) +0.04s (+ 0.37%) 9.92s 10.09s
TFS - node (v10.16.3, x64)
Memory used 302,091k (± 0.03%) 302,023k (± 0.03%) -68k (- 0.02%) 301,831k 302,274k
Parse Time 1.22s (± 0.39%) 1.22s (± 0.72%) -0.00s (- 0.25%) 1.20s 1.24s
Bind Time 0.66s (± 1.60%) 0.67s (± 1.34%) +0.00s (+ 0.30%) 0.64s 0.68s
Check Time 4.40s (± 0.57%) 4.44s (± 0.58%) +0.04s (+ 0.93%) 4.37s 4.49s
Emit Time 2.88s (± 1.04%) 2.91s (± 1.55%) +0.03s (+ 0.97%) 2.83s 3.04s
Total Time 9.17s (± 0.35%) 9.23s (± 0.56%) +0.06s (+ 0.70%) 9.14s 9.37s
material-ui - node (v10.16.3, x64)
Memory used 459,420k (± 0.01%) 459,103k (± 0.01%) -317k (- 0.07%) 459,018k 459,189k
Parse Time 2.05s (± 0.65%) 2.04s (± 0.52%) -0.00s (- 0.15%) 2.02s 2.06s
Bind Time 0.66s (± 1.21%) 0.65s (± 1.80%) -0.01s (- 1.66%) 0.63s 0.68s
Check Time 12.93s (± 0.78%) 12.96s (± 0.73%) +0.03s (+ 0.23%) 12.74s 13.15s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.64s (± 0.68%) 15.66s (± 0.64%) +0.02s (+ 0.12%) 15.43s 15.85s
Angular - node (v12.1.0, x64)
Memory used 321,159k (± 0.03%) 320,685k (± 0.03%) -474k (- 0.15%) 320,371k 320,838k
Parse Time 2.01s (± 0.32%) 2.00s (± 0.44%) -0.01s (- 0.25%) 1.98s 2.02s
Bind Time 0.81s (± 0.84%) 0.80s (± 0.74%) -0.00s (- 0.12%) 0.79s 0.82s
Check Time 4.65s (± 0.47%) 4.66s (± 0.55%) +0.00s (+ 0.09%) 4.62s 4.71s
Emit Time 5.38s (± 0.73%) 5.39s (± 1.04%) +0.01s (+ 0.24%) 5.31s 5.59s
Total Time 12.85s (± 0.37%) 12.86s (± 0.50%) +0.01s (+ 0.07%) 12.75s 13.05s
Monaco - node (v12.1.0, x64)
Memory used 321,565k (± 0.02%) 321,535k (± 0.02%) -30k (- 0.01%) 321,421k 321,637k
Parse Time 1.55s (± 1.09%) 1.55s (± 0.65%) +0.00s (+ 0.06%) 1.53s 1.57s
Bind Time 0.69s (± 0.52%) 0.69s (± 0.89%) -0.00s (- 0.43%) 0.67s 0.70s
Check Time 4.68s (± 0.45%) 4.72s (± 0.47%) +0.04s (+ 0.81%) 4.67s 4.77s
Emit Time 2.82s (± 0.78%) 2.81s (± 0.40%) -0.01s (- 0.36%) 2.79s 2.84s
Total Time 9.74s (± 0.38%) 9.77s (± 0.31%) +0.03s (+ 0.30%) 9.68s 9.83s
TFS - node (v12.1.0, x64)
Memory used 286,485k (± 0.02%) 286,528k (± 0.02%) +43k (+ 0.01%) 286,449k 286,668k
Parse Time 1.23s (± 0.85%) 1.23s (± 0.86%) +0.00s (+ 0.08%) 1.21s 1.26s
Bind Time 0.64s (± 0.47%) 0.64s (± 0.74%) +0.01s (+ 0.78%) 0.63s 0.65s
Check Time 4.31s (± 0.58%) 4.34s (± 0.50%) +0.03s (+ 0.63%) 4.29s 4.38s
Emit Time 2.92s (± 0.63%) 2.94s (± 1.08%) +0.03s (+ 0.93%) 2.89s 3.04s
Total Time 9.10s (± 0.53%) 9.16s (± 0.54%) +0.06s (+ 0.62%) 9.06s 9.31s
material-ui - node (v12.1.0, x64)
Memory used 437,806k (± 0.01%) 437,509k (± 0.01%) -297k (- 0.07%) 437,352k 437,603k
Parse Time 2.03s (± 0.89%) 2.03s (± 0.37%) +0.00s (+ 0.05%) 2.01s 2.04s
Bind Time 0.63s (± 1.05%) 0.62s (± 0.96%) -0.01s (- 0.79%) 0.61s 0.64s
Check Time 11.61s (± 1.33%) 11.62s (± 0.85%) +0.01s (+ 0.08%) 11.38s 11.90s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 14.27s (± 1.17%) 14.27s (± 0.70%) 0.00s ( 0.00%) 14.03s 14.56s
Angular - node (v8.9.0, x64)
Memory used 340,410k (± 0.02%) 340,058k (± 0.01%) -352k (- 0.10%) 339,965k 340,204k
Parse Time 2.54s (± 0.56%) 2.52s (± 0.35%) -0.01s (- 0.55%) 2.51s 2.55s
Bind Time 0.86s (± 1.08%) 0.84s (± 0.44%) -0.01s (- 1.52%) 0.84s 0.85s
Check Time 5.36s (± 0.51%) 5.38s (± 0.66%) +0.02s (+ 0.37%) 5.32s 5.49s
Emit Time 5.92s (± 1.10%) 5.88s (± 1.43%) -0.04s (- 0.68%) 5.69s 6.04s
Total Time 14.68s (± 0.54%) 14.64s (± 0.64%) -0.05s (- 0.32%) 14.39s 14.83s
Monaco - node (v8.9.0, x64)
Memory used 340,489k (± 0.02%) 340,458k (± 0.02%) -31k (- 0.01%) 340,288k 340,533k
Parse Time 1.88s (± 0.33%) 1.89s (± 0.82%) +0.01s (+ 0.58%) 1.87s 1.95s
Bind Time 0.88s (± 0.59%) 0.89s (± 0.67%) +0.01s (+ 0.57%) 0.88s 0.90s
Check Time 5.42s (± 0.36%) 5.46s (± 0.46%) +0.04s (+ 0.70%) 5.40s 5.53s
Emit Time 3.23s (± 0.51%) 3.23s (± 0.78%) +0.00s (+ 0.12%) 3.19s 3.31s
Total Time 11.41s (± 0.27%) 11.47s (± 0.36%) +0.05s (+ 0.47%) 11.38s 11.57s
TFS - node (v8.9.0, x64)
Memory used 303,835k (± 0.03%) 303,825k (± 0.01%) -9k (- 0.00%) 303,742k 303,926k
Parse Time 1.55s (± 0.43%) 1.54s (± 0.53%) -0.01s (- 0.45%) 1.52s 1.56s
Bind Time 0.68s (± 0.73%) 0.67s (± 0.83%) -0.00s (- 0.59%) 0.66s 0.68s
Check Time 5.00s (± 1.41%) 5.13s (± 1.80%) +0.13s (+ 2.58%) 4.95s 5.29s
Emit Time 3.07s (± 2.85%) 3.02s (± 2.68%) -0.05s (- 1.47%) 2.90s 3.17s
Total Time 10.29s (± 0.40%) 10.36s (± 0.41%) +0.07s (+ 0.70%) 10.29s 10.46s
material-ui - node (v8.9.0, x64)
Memory used 463,677k (± 0.02%) 463,395k (± 0.02%) -282k (- 0.06%) 463,266k 463,711k
Parse Time 2.40s (± 0.71%) 2.40s (± 0.43%) +0.00s (+ 0.08%) 2.37s 2.42s
Bind Time 0.78s (± 1.47%) 0.77s (± 1.55%) -0.01s (- 0.64%) 0.76s 0.81s
Check Time 17.24s (± 1.02%) 17.12s (± 0.70%) -0.12s (- 0.70%) 16.92s 17.38s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 20.41s (± 0.90%) 20.29s (± 0.64%) -0.12s (- 0.59%) 20.11s 20.62s
Angular - node (v8.9.0, x86)
Memory used 195,358k (± 0.04%) 195,100k (± 0.02%) -257k (- 0.13%) 195,006k 195,194k
Parse Time 2.48s (± 0.72%) 2.47s (± 0.75%) -0.01s (- 0.56%) 2.43s 2.53s
Bind Time 0.99s (± 0.78%) 0.99s (± 0.81%) -0.00s (- 0.10%) 0.98s 1.01s
Check Time 4.87s (± 0.60%) 4.88s (± 0.74%) +0.01s (+ 0.29%) 4.79s 4.95s
Emit Time 5.96s (± 0.92%) 5.94s (± 1.02%) -0.03s (- 0.44%) 5.75s 6.06s
Total Time 14.30s (± 0.59%) 14.27s (± 0.72%) -0.02s (- 0.17%) 13.97s 14.46s
Monaco - node (v8.9.0, x86)
Memory used 193,509k (± 0.03%) 193,512k (± 0.02%) +4k (+ 0.00%) 193,437k 193,596k
Parse Time 1.92s (± 1.16%) 1.91s (± 0.67%) -0.01s (- 0.52%) 1.89s 1.95s
Bind Time 0.70s (± 0.79%) 0.70s (± 0.68%) +0.00s (+ 0.14%) 0.69s 0.71s
Check Time 5.49s (± 1.29%) 5.53s (± 1.04%) +0.04s (+ 0.73%) 5.36s 5.66s
Emit Time 2.74s (± 4.09%) 2.72s (± 3.62%) -0.02s (- 0.69%) 2.62s 3.11s
Total Time 10.86s (± 0.53%) 10.87s (± 0.81%) +0.01s (+ 0.13%) 10.72s 11.10s
TFS - node (v8.9.0, x86)
Memory used 173,762k (± 0.03%) 173,736k (± 0.02%) -27k (- 0.02%) 173,682k 173,803k
Parse Time 1.59s (± 0.89%) 1.59s (± 1.04%) +0.00s (+ 0.32%) 1.56s 1.65s
Bind Time 0.64s (± 0.69%) 0.64s (± 0.47%) -0.00s (- 0.62%) 0.63s 0.64s
Check Time 4.68s (± 0.52%) 4.70s (± 0.63%) +0.02s (+ 0.41%) 4.65s 4.78s
Emit Time 2.81s (± 1.00%) 2.79s (± 1.56%) -0.02s (- 0.64%) 2.68s 2.89s
Total Time 9.71s (± 0.48%) 9.72s (± 0.77%) +0.01s (+ 0.07%) 9.53s 9.85s
material-ui - node (v8.9.0, x86)
Memory used 262,564k (± 0.01%) 262,405k (± 0.02%) -159k (- 0.06%) 262,291k 262,473k
Parse Time 2.45s (± 0.35%) 2.44s (± 0.42%) -0.01s (- 0.29%) 2.42s 2.47s
Bind Time 0.67s (± 1.12%) 0.67s (± 1.25%) -0.00s (- 0.30%) 0.65s 0.68s
Check Time 15.78s (± 0.88%) 15.79s (± 0.66%) +0.01s (+ 0.07%) 15.58s 16.02s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 18.90s (± 0.72%) 18.90s (± 0.54%) +0.00s (+ 0.02%) 18.68s 19.11s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-166-generic
Architecturex64
Available Memory16 GB
Available Memory1 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v8.9.0, x64)
  • node (v8.9.0, x86)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v8.9.0, x64)
  • Angular - node (v8.9.0, x86)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v8.9.0, x64)
  • Monaco - node (v8.9.0, x86)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v8.9.0, x64)
  • TFS - node (v8.9.0, x86)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v8.9.0, x64)
  • material-ui - node (v8.9.0, x86)
Benchmark Name Iterations
Current 39403 10
Baseline master 10

sandersn
sandersn reviewed Jul 13, 2020
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like the right thing, but can you run the perf test again after merging from master? It looks a tiny bit slower, but it could just be noise.

@Kingwl
Copy link
Contributor Author

Kingwl commented Jul 15, 2020

@typescript-bot perf test.
@typescript-bot perf test.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jul 15, 2020 •
edited
Loading

Heya @Kingwl, I've started to run the perf test suite on this PR at 660b399. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@Kingwl
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..39403

Metric master 39403 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 343,501k (± 0.02%) 342,970k (± 0.02%) -531k (- 0.15%) 342,798k 343,110k
Parse Time 2.00s (± 0.56%) 2.00s (± 0.78%) -0.00s (- 0.25%) 1.97s 2.04s
Bind Time 0.81s (± 0.84%) 0.81s (± 0.55%) -0.00s (- 0.25%) 0.80s 0.82s
Check Time 4.74s (± 0.47%) 4.74s (± 0.40%) -0.00s (- 0.00%) 4.69s 4.78s
Emit Time 5.18s (± 0.74%) 5.18s (± 0.69%) -0.00s (- 0.02%) 5.12s 5.29s
Total Time 12.73s (± 0.42%) 12.73s (± 0.44%) -0.00s (- 0.04%) 12.66s 12.91s
Monaco - node (v10.16.3, x64)
Memory used 338,946k (± 0.02%) 338,970k (± 0.03%) +24k (+ 0.01%) 338,791k 339,206k
Parse Time 1.58s (± 0.67%) 1.58s (± 0.52%) +0.01s (+ 0.44%) 1.56s 1.60s
Bind Time 0.71s (± 0.91%) 0.71s (± 0.66%) +0.00s (+ 0.28%) 0.70s 0.72s
Check Time 4.88s (± 0.57%) 4.91s (± 0.47%) +0.02s (+ 0.47%) 4.84s 4.95s
Emit Time 2.75s (± 0.27%) 2.75s (± 0.85%) -0.01s (- 0.22%) 2.71s 2.81s
Total Time 9.92s (± 0.36%) 9.95s (± 0.40%) +0.03s (+ 0.31%) 9.87s 10.05s
TFS - node (v10.16.3, x64)
Memory used 301,894k (± 0.02%) 301,836k (± 0.02%) -58k (- 0.02%) 301,720k 301,949k
Parse Time 1.21s (± 0.58%) 1.21s (± 0.74%) -0.00s (- 0.33%) 1.18s 1.22s
Bind Time 0.66s (± 0.98%) 0.67s (± 0.51%) +0.01s (+ 0.76%) 0.66s 0.67s
Check Time 4.37s (± 0.48%) 4.38s (± 0.44%) +0.01s (+ 0.16%) 4.34s 4.43s
Emit Time 2.90s (± 0.64%) 2.91s (± 0.90%) +0.01s (+ 0.28%) 2.87s 2.98s
Total Time 9.15s (± 0.30%) 9.17s (± 0.30%) +0.02s (+ 0.21%) 9.12s 9.22s
material-ui - node (v10.16.3, x64)
Memory used 459,008k (± 0.01%) 458,778k (± 0.01%) -231k (- 0.05%) 458,672k 458,886k
Parse Time 2.04s (± 0.37%) 2.04s (± 0.48%) +0.00s (+ 0.15%) 2.02s 2.06s
Bind Time 0.65s (± 0.89%) 0.65s (± 0.72%) 0.00s ( 0.00%) 0.64s 0.66s
Check Time 12.85s (± 0.56%) 12.87s (± 0.37%) +0.02s (+ 0.16%) 12.78s 12.96s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.54s (± 0.50%) 15.56s (± 0.31%) +0.02s (+ 0.14%) 15.46s 15.64s
Angular - node (v12.1.0, x64)
Memory used 320,747k (± 0.02%) 320,358k (± 0.02%) -389k (- 0.12%) 320,208k 320,529k
Parse Time 1.98s (± 0.62%) 1.98s (± 0.63%) -0.01s (- 0.25%) 1.96s 2.01s
Bind Time 0.80s (± 0.60%) 0.80s (± 0.91%) +0.00s (+ 0.13%) 0.79s 0.82s
Check Time 4.60s (± 0.38%) 4.63s (± 0.52%) +0.03s (+ 0.63%) 4.57s 4.70s
Emit Time 5.33s (± 0.51%) 5.36s (± 1.06%) +0.02s (+ 0.45%) 5.26s 5.55s
Total Time 12.71s (± 0.23%) 12.76s (± 0.39%) +0.05s (+ 0.36%) 12.64s 12.88s
Monaco - node (v12.1.0, x64)
Memory used 321,459k (± 0.02%) 321,456k (± 0.02%) -3k (- 0.00%) 321,323k 321,594k
Parse Time 1.54s (± 0.88%) 1.54s (± 1.01%) +0.00s (+ 0.26%) 1.51s 1.58s
Bind Time 0.68s (± 0.54%) 0.69s (± 0.94%) +0.00s (+ 0.44%) 0.68s 0.71s
Check Time 4.66s (± 0.42%) 4.68s (± 0.50%) +0.02s (+ 0.52%) 4.63s 4.73s
Emit Time 2.80s (± 0.68%) 2.79s (± 0.78%) -0.00s (- 0.14%) 2.76s 2.83s
Total Time 9.68s (± 0.41%) 9.71s (± 0.42%) +0.02s (+ 0.25%) 9.61s 9.77s
TFS - node (v12.1.0, x64)
Memory used 286,433k (± 0.02%) 286,493k (± 0.02%) +60k (+ 0.02%) 286,330k 286,679k
Parse Time 1.23s (± 0.41%) 1.23s (± 0.40%) +0.00s (+ 0.08%) 1.22s 1.24s
Bind Time 0.64s (± 1.25%) 0.64s (± 1.08%) -0.01s (- 1.09%) 0.62s 0.65s
Check Time 4.27s (± 0.45%) 4.31s (± 0.83%) +0.04s (+ 0.87%) 4.22s 4.41s
Emit Time 2.90s (± 0.62%) 2.93s (± 0.75%) +0.03s (+ 1.00%) 2.89s 2.99s
Total Time 9.03s (± 0.21%) 9.10s (± 0.54%) +0.06s (+ 0.70%) 8.96s 9.21s
material-ui - node (v12.1.0, x64)
Memory used 437,330k (± 0.05%) 436,944k (± 0.07%) -387k (- 0.09%) 436,041k 437,272k
Parse Time 2.01s (± 0.25%) 2.02s (± 0.77%) +0.01s (+ 0.40%) 2.00s 2.06s
Bind Time 0.62s (± 0.76%) 0.62s (± 0.76%) 0.00s ( 0.00%) 0.61s 0.63s
Check Time 11.55s (± 0.91%) 11.59s (± 0.64%) +0.04s (+ 0.35%) 11.44s 11.73s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 14.19s (± 0.75%) 14.24s (± 0.51%) +0.05s (+ 0.35%) 14.11s 14.39s
Angular - node (v8.9.0, x64)
Memory used 340,074k (± 0.02%) 339,684k (± 0.02%) -390k (- 0.11%) 339,585k 339,776k
Parse Time 2.53s (± 0.31%) 2.53s (± 0.49%) -0.00s (- 0.08%) 2.51s 2.56s
Bind Time 0.84s (± 0.56%) 0.84s (± 0.81%) +0.00s (+ 0.48%) 0.83s 0.86s
Check Time 5.35s (± 0.56%) 5.37s (± 0.54%) +0.02s (+ 0.43%) 5.32s 5.44s
Emit Time 5.88s (± 0.83%) 5.93s (± 1.24%) +0.05s (+ 0.83%) 5.71s 6.05s
Total Time 14.60s (± 0.41%) 14.67s (± 0.59%) +0.07s (+ 0.47%) 14.42s 14.83s
Monaco - node (v8.9.0, x64)
Memory used 340,257k (± 0.01%) 340,296k (± 0.01%) +38k (+ 0.01%) 340,221k 340,413k
Parse Time 1.87s (± 0.37%) 1.88s (± 0.56%) +0.01s (+ 0.32%) 1.85s 1.90s
Bind Time 0.88s (± 0.80%) 0.88s (± 0.39%) -0.00s (- 0.23%) 0.87s 0.88s
Check Time 5.40s (± 0.40%) 5.41s (± 0.40%) +0.01s (+ 0.17%) 5.37s 5.47s
Emit Time 3.23s (± 0.83%) 3.21s (± 0.66%) -0.02s (- 0.74%) 3.15s 3.25s
Total Time 11.38s (± 0.36%) 11.37s (± 0.24%) -0.01s (- 0.11%) 11.28s 11.43s
TFS - node (v8.9.0, x64)
Memory used 303,658k (± 0.02%) 303,661k (± 0.02%) +2k (+ 0.00%) 303,498k 303,756k
Parse Time 1.54s (± 0.52%) 1.55s (± 0.50%) +0.01s (+ 0.58%) 1.54s 1.57s
Bind Time 0.66s (± 0.72%) 0.67s (± 0.78%) +0.01s (+ 0.90%) 0.65s 0.68s
Check Time 5.06s (± 1.38%) 5.10s (± 1.71%) +0.04s (+ 0.75%) 4.92s 5.22s
Emit Time 2.97s (± 2.36%) 3.00s (± 2.32%) +0.03s (+ 1.14%) 2.92s 3.17s
Total Time 10.24s (± 0.23%) 10.32s (± 0.42%) +0.08s (+ 0.79%) 10.24s 10.44s
material-ui - node (v8.9.0, x64)
Memory used 463,303k (± 0.02%) 463,013k (± 0.01%) -290k (- 0.06%) 462,916k 463,089k
Parse Time 2.39s (± 0.71%) 2.39s (± 0.60%) -0.00s (- 0.13%) 2.36s 2.41s
Bind Time 0.77s (± 1.07%) 0.77s (± 1.22%) -0.00s (- 0.13%) 0.75s 0.79s
Check Time 17.13s (± 0.81%) 17.08s (± 0.84%) -0.05s (- 0.30%) 16.83s 17.45s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 20.30s (± 0.72%) 20.24s (± 0.73%) -0.06s (- 0.28%) 20.01s 20.64s
Angular - node (v8.9.0, x86)
Memory used 195,099k (± 0.03%) 194,847k (± 0.03%) -252k (- 0.13%) 194,750k 195,026k
Parse Time 2.46s (± 0.82%) 2.44s (± 0.79%) -0.03s (- 1.06%) 2.39s 2.47s
Bind Time 0.99s (± 1.08%) 0.98s (± 0.61%) -0.02s (- 1.51%) 0.96s 0.99s
Check Time 4.82s (± 0.46%) 4.81s (± 0.65%) -0.01s (- 0.21%) 4.76s 4.89s
Emit Time 5.89s (± 1.11%) 5.93s (± 0.85%) +0.04s (+ 0.66%) 5.81s 6.08s
Total Time 14.16s (± 0.50%) 14.15s (± 0.61%) -0.01s (- 0.09%) 13.98s 14.42s
Monaco - node (v8.9.0, x86)
Memory used 193,387k (± 0.01%) 193,374k (± 0.02%) -13k (- 0.01%) 193,316k 193,429k
Parse Time 1.91s (± 0.49%) 1.90s (± 0.66%) -0.01s (- 0.31%) 1.89s 1.95s
Bind Time 0.70s (± 0.52%) 0.70s (± 0.83%) +0.00s (+ 0.14%) 0.69s 0.71s
Check Time 5.48s (± 0.41%) 5.51s (± 0.53%) +0.03s (+ 0.47%) 5.45s 5.57s
Emit Time 2.68s (± 0.68%) 2.67s (± 1.01%) -0.01s (- 0.37%) 2.62s 2.74s
Total Time 10.77s (± 0.35%) 10.78s (± 0.48%) +0.01s (+ 0.09%) 10.66s 10.87s
TFS - node (v8.9.0, x86)
Memory used 173,692k (± 0.03%) 173,688k (± 0.03%) -4k (- 0.00%) 173,608k 173,833k
Parse Time 1.59s (± 1.20%) 1.60s (± 0.99%) +0.01s (+ 0.50%) 1.57s 1.63s
Bind Time 0.64s (± 0.58%) 0.64s (± 0.63%) +0.00s (+ 0.63%) 0.63s 0.65s
Check Time 4.67s (± 1.20%) 4.66s (± 0.55%) -0.01s (- 0.17%) 4.62s 4.73s
Emit Time 2.80s (± 1.89%) 2.82s (± 1.29%) +0.02s (+ 0.89%) 2.77s 2.91s
Total Time 9.69s (± 0.71%) 9.72s (± 0.52%) +0.03s (+ 0.28%) 9.61s 9.82s
material-ui - node (v8.9.0, x86)
Memory used 262,370k (± 0.02%) 262,215k (± 0.01%) -155k (- 0.06%) 262,168k 262,296k
Parse Time 2.45s (± 0.66%) 2.46s (± 0.78%) +0.00s (+ 0.12%) 2.42s 2.49s
Bind Time 0.67s (± 1.49%) 0.66s (± 0.89%) -0.01s (- 0.90%) 0.65s 0.68s
Check Time 15.60s (± 0.62%) 15.71s (± 0.37%) +0.11s (+ 0.68%) 15.59s 15.82s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 18.73s (± 0.60%) 18.83s (± 0.31%) +0.10s (+ 0.53%) 18.73s 18.94s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-166-generic
Architecturex64
Available Memory16 GB
Available Memory1 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v8.9.0, x64)
  • node (v8.9.0, x86)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v8.9.0, x64)
  • Angular - node (v8.9.0, x86)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v8.9.0, x64)
  • Monaco - node (v8.9.0, x86)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v8.9.0, x64)
  • TFS - node (v8.9.0, x86)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v8.9.0, x64)
  • material-ui - node (v8.9.0, x86)
Benchmark Name Iterations
Current 39403 10
Baseline master 10

sandersn
sandersn approved these changes Jul 15, 2020
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second round of perf results are not significantly slower except in a couple of cases. I think there is probably a very slight slowdown, but also that it's worth it to have the feature work right.

@sandersn
Copy link
Member

This is ready to merge whenever github's merge-checking code allows me to push the merge button.

@sandersn sandersn merged commit fcd4fcb into microsoft:master Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersn sandersn sandersn approved these changes

Assignees

@sandersn sandersn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kingwl @typescript-bot @sandersn