Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve deprecated suggestion node position #39702

Merged
merged 4 commits into from
Aug 11, 2020
Merged

Improve deprecated suggestion node position #39702

merged 4 commits into from
Aug 11, 2020

Conversation

Kingwl
Copy link
Contributor

@Kingwl Kingwl commented Jul 22, 2020

Fixes #39686

@typescript-bot typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Jul 22, 2020
DickvdBrink
DickvdBrink reviewed Jul 22, 2020
View reviewed changes
src/compiler/checker.ts
}
}

function getSignautreSuggestionNode(node: CallLikeExpression): Node {
Copy link
Contributor

@DickvdBrink DickvdBrink Jul 22, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: getSignautreSuggestionNode -> getSignatureSuggestionNode

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. Yes... sure.

orta
orta approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@orta orta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@DanielRosenwasser
Copy link
Member

@typescript-bot cherry-pick this to release-4.0

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 11, 2020 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-4.0 on this PR at 58f6f3d. You can monitor the build here.

@DanielRosenwasser DanielRosenwasser merged commit 57e2fe0 into microsoft:master Aug 11, 2020
typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Aug 11, 2020
@Kingwl @typescript-bot
Cherry-pick PR microsoft#39702 into release-4.0
a9d4c80 
Component commits:
cd5dde5 Improve deprecated suggestion node position

6e39ee7 fix typo

a593fd0 Simplify code

58f6f3d merge helper function
@typescript-bot typescript-bot mentioned this pull request Aug 11, 2020
Merged
@typescript-bot
Copy link
Collaborator

Hey @DanielRosenwasser, I've opened #39985 for you.

DanielRosenwasser pushed a commit that referenced this pull request Aug 12, 2020
@Kingwl
Cherry-pick PR #39702 into release-4.0 (#39985)
7558de6 
Component commits:
cd5dde5 Improve deprecated suggestion node position

6e39ee7 fix typo

a593fd0 Simplify code

58f6f3d merge helper function

Co-authored-by: kingwl <kingwenlu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DickvdBrink DickvdBrink DickvdBrink left review comments

@orta orta orta approved these changes

Assignees

@Kingwl Kingwl

Labels
For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Only mark function/method name as deprecated instead of entire call expression
5 participants
@Kingwl @DanielRosenwasser @typescript-bot @orta @DickvdBrink