Add missing 'importName' for private field helpers #39932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Milestone Bug
Contributor
Author
|
Suggestions aren't working again. /CC @weswigham, @sandersn for review @DanielRosenwasser this might be worth taking for 4.0. |
Member
|
@typescript-bot cherry-pick this to release-4.0 |
Collaborator
|
Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into |
Collaborator
|
Hey @DanielRosenwasser, I've opened #39933 for you. |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Aug 6, 2020
Component commits: f53db98 Add missing 'importName' for private field helpers
weswigham
approved these changes
Aug 6, 2020
DanielRosenwasser
pushed a commit
that referenced
this pull request
Aug 6, 2020
Component commits: f53db98 Add missing 'importName' for private field helpers Co-authored-by: Ron Buckton <rbuckton@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
importNameproperties for the class private field get/set helpers so that they work correctly with--importHelpers.Fixes #36841