Declaration emitter cleanup #4068
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: src/compiler/checker.ts
Conflicts: src/compiler/checker.ts src/compiler/declarationEmitter.ts src/compiler/diagnosticInformationMap.generated.ts src/compiler/diagnosticMessages.json src/compiler/types.ts
| @@ -1657,7 +1513,7 @@ namespace ts { | |||
| // Unnamed function expressions, arrow functions, and unnamed class expressions have reserved names that | |||
| // we don't want to display | |||
| if (!isReservedMemberName(symbol.name)) { | |||
| buildSymbolDisplay(symbol, writer, enclosingDeclaration, SymbolFlags.Type); | |||
| buildSymbolDisplay(symbol, writer, enclosingDeclaration, SymbolFlags.Type, undefined, undefined, /*isTypeSymbol*/true); | |||
There was a problem hiding this comment.
Use named parameters here.
|
In
|
Conflicts: src/compiler/declarationEmitter.ts src/compiler/types.ts
This was referenced Aug 24, 2015
Conflicts: src/compiler/checker.ts src/compiler/declarationEmitter.ts src/compiler/diagnosticInformationMap.generated.ts src/compiler/diagnosticMessages.json src/compiler/types.ts tests/baselines/reference/chainedImportAlias.symbols tests/baselines/reference/es6ImportNamedImportInIndirectExportAssignment.symbols
|
closing for now. will refresh and resubmit. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first set of changes to get declaration bundling working. the first step is to split the emitter logic into two phases; the first to collect declarations that we need to emit (preprocess) and the second to write them (write). With these changes there should not be any functional changes, just error messages and reporting differences. I will be sending out changes to support --out with --module for declaration and then another set for bundling.
Note for reviewers, declarationEmitter.ts has changed significantly, so i would look at the file as whole instead of diffs. changes to other files are fairly limited though, so diffs should be sufficient.