-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax index signature checks for type any #4074
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -5251,7 +5251,7 @@ namespace ts { | |||
return indexTypesIdenticalTo(IndexKind.String, source, target); | |||
} | |||
let targetType = getIndexTypeOfType(target, IndexKind.String); | |||
if (targetType) { | |||
if (targetType && !(targetType.flags & TypeFlags.Any)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use isTypeAny
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would just add function call and a redundant null check.
👍 |
@JsonFreeman Agreed. |
👍 |
ahejlsberg
added a commit
that referenced
this pull request
Jul 30, 2015
Relax index signature checks for type any
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, a type without an index signature is considered related to a type with an index signature if the type of that index signature is
any
. For example:The assignment
x = y
was previously considered an error becausey
has no index signature. However, given that an index signature of typeany
doesn't actually constrain properties in the type, the assignment is now permitted.This issue was originally reported by @joewood here.