Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(3758): Object literals in an assignment pattern do not get completions #40976

Merged
merged 1 commit into from
Oct 8, 2020
Merged

fix(3758): Object literals in an assignment pattern do not get completions #40976

merged 1 commit into from
Oct 8, 2020

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #3758

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Oct 7, 2020
@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Oct 7, 2020 •
edited
Loading

Holy crap, I saw this issue weeks ago and didn't expect this one to ever get fixed.

@DanielRosenwasser
Copy link
Member

@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 7, 2020 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at 181a337. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 7, 2020 •
edited
Loading

Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/87425/artifacts?artifactName=tgz&fileId=C220A3FAC4035A31F460DB83D1F095ECC8F6369A31D2C4414AC695D41AE0755302&fileName=/typescript-4.1.0-insiders.20201007.tgz"
    }
}

and then running npm install.

There is also a playground for this build.

@a-tarasyuk
Copy link
Contributor Author

@DanielRosenwasser I noticed this issue a couple of weeks ago and suddenly found an open issue on GitHub that I had in my backlog 😄

@DanielRosenwasser DanielRosenwasser merged commit 23c5f92 into microsoft:master Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser left review comments

Assignees
No one assigned
Labels
For Backlog Bug PRs that fix a backlog bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Object literals in an assignment pattern do not get completions
3 participants
@a-tarasyuk @DanielRosenwasser @typescript-bot