Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Experiment] Enum annotation sugar #41110

Closed
wants to merge 3 commits into from
Closed

Conversation

Kingwl
Copy link
Contributor

@Kingwl Kingwl commented Oct 15, 2020

Seems not a big feature(2-4 lines for core), but a nice sugar.

Fixes #16464

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Oct 15, 2020
@Kingwl
Copy link
Contributor Author

Kingwl commented Oct 15, 2020

@typescript-bot pack this.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 15, 2020

Heya @Kingwl, I've started to run the tarball bundle task on this PR at aadd9cd. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 15, 2020

Hey @Kingwl, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/87482/artifacts?artifactName=tgz&fileId=589E795A3F50B70EDD434977F6DDF87141191CE66212826349422EDEEC02744E02&fileName=/typescript-4.1.0-insiders.20201015.tgz"
    }
}

and then running npm install.


There is also a playground for this build.

@sandersn sandersn added the Experiment A fork with an experimental idea which might not make it into master label Oct 27, 2020
Co-authored-by: Bread <60681223+vBread@users.noreply.github.com>
@typescript-bot
Copy link
Collaborator

The TypeScript team hasn't accepted the linked issue #16464. If you can get it accepted, this PR will have a better chance of being reviewed.

@Kingwl
Copy link
Contributor Author

Kingwl commented Mar 2, 2021

Thanks!

@wangziling
Copy link

wangziling commented May 8, 2021

Thanks @Kingwl, very helpful~

@RyanCavanaugh RyanCavanaugh marked this pull request as draft May 11, 2021 16:55
@sandersn
Copy link
Member

This experiment is pretty old, so I'm going to close it to reduce the number of open PRs.

@sandersn sandersn closed this May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Experiment A fork with an experimental idea which might not make it into master For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

String Enum Initializer
5 participants