Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(26217): Add missing member fix should work for missing function #41215

Merged
merged 6 commits into from
Jan 9, 2021
Merged

feat(26217): Add missing member fix should work for missing function #41215

merged 6 commits into from
Jan 9, 2021

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #26217

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Oct 23, 2020
@a-tarasyuk a-tarasyuk marked this pull request as ready for review October 25, 2020 13:31
@sandersn sandersn self-assigned this Nov 18, 2020
@DanielRosenwasser DanielRosenwasser mentioned this pull request Nov 19, 2020
Closed
@DanielRosenwasser
Copy link
Member

@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Dec 2, 2020 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at dc448f9. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Dec 2, 2020 •
edited
Loading

Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/90205/artifacts?artifactName=tgz&fileId=C92047E7D012B4C56A628CDC8A2082B9C79E19DE6093DAD2FAFB6036C022EA4902&fileName=/typescript-4.2.0-insiders.20201202.tgz"
    }
}

and then running npm install.

There is also a playground for this build.

sandersn
sandersn approved these changes Dec 19, 2020
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of early comments -- I've looked at the tests, and they look good, but haven't looked at the code.

tests/cases/fourslash/importNameCodeFixNewImportNodeModules5.ts Outdated Show resolved Hide resolved
src/services/codefixes/helpers.ts Outdated Show resolved Hide resolved
@OliverJAsh OliverJAsh mentioned this pull request Dec 29, 2020
Open
5 tasks
jessetrinity
jessetrinity reviewed Jan 5, 2021
View reviewed changes
Copy link
Contributor

@jessetrinity jessetrinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple of questions but otherwise looks great 👍

src/services/codefixes/fixAddMissingMember.ts Show resolved Hide resolved
src/services/codefixes/helpers.ts Outdated Show resolved Hide resolved
src/services/codefixes/helpers.ts Outdated Show resolved Hide resolved
@jessetrinity jessetrinity merged commit 0c58ede into microsoft:master Jan 9, 2021
Zzzen pushed a commit to Zzzen/TypeScript that referenced this pull request Jan 16, 2021
@a-tarasyuk @Zzzen
feat(26217): Add missing member fix should work for missing function (m…
dfd7d97 
…icrosoft#41215)

* feat(26217): Add missing function declaration QF

* use codeFixAvailable instead of codeFix

* add diagnostics messages 'Method not implemented.' and 'Function not implemented.'

* use codeFixAvailable instead of codeFix

* fix signature types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessetrinity jessetrinity jessetrinity approved these changes

@sandersn sandersn sandersn approved these changes

@DanielRosenwasser DanielRosenwasser Awaiting requested review from DanielRosenwasser

Assignees

@sandersn sandersn

Labels
For Backlog Bug PRs that fix a backlog bug
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add missing member fix should work for missing function
5 participants
@a-tarasyuk @DanielRosenwasser @typescript-bot @sandersn @jessetrinity