Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try get method type from super class #41303

Closed
wants to merge 4 commits into from
Closed

Try get method type from super class #41303

wants to merge 4 commits into from

Conversation

Kingwl
Copy link
Contributor

@Kingwl Kingwl commented Oct 28, 2020

Fixes #23911

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Oct 28, 2020
@Kingwl Kingwl changed the title Try get type from super type Try get method type from super class Oct 28, 2020
@typescript-bot
Copy link
Collaborator

The TypeScript team hasn't accepted the linked issue #23911. This makes it less likely that we'll review or accept this PR. Try to get the originating issue accepted.

@sandersn
Copy link
Member

sandersn commented Nov 2, 2020

@typescript-bot user test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 2, 2020 •
edited
Loading

Heya @sandersn, I've started to run the parallelized community code test suite on this PR at 7a40f01. You can monitor the build here.

@typescript-bot typescript-bot mentioned this pull request Nov 2, 2020
Open
@typescript-bot
Copy link
Collaborator

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

@Kingwl
Copy link
Contributor Author

Kingwl commented Nov 19, 2020

I have some question:

  1. Should we handle the type check both of contextual type and declaration type?
  2. Should we check if method name is not literal name?

@Kingwl Kingwl mentioned this pull request Feb 25, 2021
Closed
@Kingwl Kingwl closed this Feb 25, 2021
@Kingwl Kingwl deleted the derived_parameter_type branch February 25, 2021 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sandersn sandersn

@weswigham weswigham

Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Experiment with always using parameters from base types for derived methods
4 participants
@Kingwl @typescript-bot @sandersn @weswigham