Use hash of source file text as version for the source file in tsserver #41938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
sheetalkamat
added
the
Experiment
sheetalkamat
force-pushed
the
tsserverSourceFileVersioning
branch
from
c605a26 to
57e397f
Compare
|
Is this still an experiment? The changes make sense to me. |
|
It is not but I dont think I can resolve all the merge conflicts for #41004 and get it reviewed before beta so i will hold off on merging this one for next release. |
sheetalkamat
changed the title
sheetalkamat
removed
the
Experiment
andrewbranch
approved these changes
Mar 31, 2021
amcasey
approved these changes
Apr 12, 2021
|
Note to self: Need to handle #43474 after the merge from master |
…ine if program is upto date
sheetalkamat
force-pushed
the
tsserverSourceFileVersioning
branch
from
9923a47 to
a400816
Compare
raghavthind2005
approved these changes
Mar 15, 2022
sheetalkamat
added
the
Experiment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that we can use tsbuildinfo that tsc emits since versions are used for file upto date ness checks.
Eg this will be needed for #41004 to work.