Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantic highlights in session based TSServer #42438

Merged
merged 1 commit into from
Jan 23, 2021

Conversation

orta
Copy link
Contributor

@orta orta commented Jan 21, 2021

Fixes #41262 - I've cloned https://github.com/microsoft/vscode/tree/dev/mjbvz/semantic-ts locally and get working results from the tokenized files. I'm pretty sure this should be it @mjbvz!

Screen Shot 2021-01-21 at 1 51 17 PM

@orta orta requested a review from weswigham January 21, 2021 14:10
@orta orta self-assigned this Jan 21, 2021
@typescript-bot
Copy link
Collaborator

Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping @sheetalkamat, @amcasey, @mjbvz, @minestarks for you. Feel free to loop in other consumers/maintainers if necessary

@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Jan 21, 2021
src/services/shims.ts Outdated Show resolved Hide resolved
@orta
Copy link
Contributor Author

orta commented Jan 21, 2021

@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 21, 2021

Heya @orta, I've started to run the tarball bundle task on this PR at ac1ac4d. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 21, 2021

Hey @orta, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/93903/artifacts?artifactName=tgz&fileId=4023455FB96E93ECEC8FD812E1AFFCEBF6E5897774A7ABA3A14D36AA78D23F9E02&fileName=/typescript-4.2.0-insiders.20210121.tgz"
    }
}

and then running npm install.


There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@4.2.0-pr-42438-3".;

@orta
Copy link
Contributor Author

orta commented Jan 23, 2021

Thanks Sheetal, it's a small change I'm pretty confident with - so I'm merging

@orta orta merged commit 154f209 into microsoft:master Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Difference in behavior with encodedSemanticClassifications-full in TS 4.1 compared to using VS Code plugin
3 participants