Code

ES private class elements#42458

Code

Merged

rbuckton merged 87 commits intomicrosoft:mastermicrosoft/TypeScript:masterfrom bloomberg:es-private-methods-and-accessorsbloomberg/TypeScript:es-private-methods-and-accessorsCopy head branch name to clipboardMar 25, 2021

Commits

Commits on Feb 3, 2021

• Added support for private identifier methods.

  dragomirtitian

  committed
  e3a3fb8

  Copy full SHA for e3a3fb8

• Added tests for private methods.

  dragomirtitian

  committed
  4ab27a2

  Copy full SHA for 4ab27a2

• Added check to only not allow private name method signatures in anything except classes.

  Show description for 6977b9f
  dragomirtitian

  committed
  6977b9f

  Copy full SHA for 6977b9f

• Added private accessors tests

  dragomirtitian

  committed
  bc8c07e

  Copy full SHA for bc8c07e

• Transform private methods

  Show description for 2760ed8
  

  mkubilayk

  authored and

  dragomirtitian

  committed
  2760ed8

  Copy full SHA for 2760ed8

• Rename shouldTransformPrivateFields

  Show description for 04af85d
  

  mkubilayk

  authored and

  dragomirtitian

  committed
  04af85d

  Copy full SHA for 04af85d

• Accept baseline

  Show description for f048d72
  

  mkubilayk

  authored and

  dragomirtitian

  committed
  f048d72

  Copy full SHA for f048d72

• Use a single WeakSet for brand-check

  Show description for f8cfb81
  

  mkubilayk

  authored and

  dragomirtitian

  committed
  f8cfb81

  Copy full SHA for f8cfb81

• Accept baseline

  Show description for 4aa4c3b
  

  mkubilayk

  authored and

  dragomirtitian

  committed
  4aa4c3b

  Copy full SHA for 4aa4c3b

• Add a test for using private methods in static field initializers

  Show description for 0ac1271
  

  mkubilayk

  authored and

  dragomirtitian

  committed
  0ac1271

  Copy full SHA for 0ac1271

• Add breaking checker test

  Show description for 7da5bd9
  

  mkubilayk

  authored and

  dragomirtitian

  committed
  7da5bd9

  Copy full SHA for 7da5bd9

• Add to instances once per-instance

  Show description for e133f60
  

  mkubilayk

  authored and

  dragomirtitian

  committed
  e133f60

  Copy full SHA for e133f60

• Accept baseline

  Show description for aa5dd8a
  

  mkubilayk

  authored and

  dragomirtitian

  committed
  aa5dd8a

  Copy full SHA for aa5dd8a

• fix: evaluate receiver and rhs expressions before throwing on readonly assignment

  Show description for a3889a7
  

  mkubilayk

  authored and

  dragomirtitian

  committed
  a3889a7

  Copy full SHA for a3889a7

• Add a test for evaluating rhs before readonly assignment

  Show description for 8952caa
  

  mkubilayk

  authored and

  dragomirtitian

  committed
  8952caa

  Copy full SHA for 8952caa

• Transpile private accessors

  Show description for dee87bb
  

  mkubilayk

  authored and

  dragomirtitian

  committed
  dee87bb

  Copy full SHA for dee87bb

• Accept baseline

  Show description for aec7e9b
  

  mkubilayk

  authored and

  dragomirtitian

  committed
  aec7e9b

  Copy full SHA for aec7e9b

• fix: handle readonly/writeonly accessors

  Show description for f3bbf0f
  

  mkubilayk

  authored and

  dragomirtitian

  committed
  f3bbf0f

  Copy full SHA for f3bbf0f

• accept baseline

  Show description for a1b59cd
  

  mkubilayk

  authored and

  dragomirtitian

  committed
  a1b59cd

  Copy full SHA for a1b59cd

• add a test for private setter without a getter

  Show description for 6b74498
  

  mkubilayk

  authored and

  dragomirtitian

  committed
  6b74498

  Copy full SHA for 6b74498

• fix: getAllUnscopedEmitHelpers

  Show description for d51f6cd
  

  mkubilayk

  authored and

  dragomirtitian

  committed
  d51f6cd

  Copy full SHA for d51f6cd

• fix: better handling of duplicate names

  Show description for c175770
  

  mkubilayk

  authored and

  dragomirtitian

  committed
  c175770

  Copy full SHA for c175770

• Fixed wrong error message for private methods in class expressions.

  dragomirtitian

  committed
  4301af5

  Copy full SHA for 4301af5

• change error message

  Show description for 3a056b2
  

  mkubilayk

  authored and

  dragomirtitian

  committed
  3a056b2

  Copy full SHA for 3a056b2

• add a test for async private methods with a higher target

  Show description for 95df2d1
  

  mkubilayk

  authored and

  dragomirtitian

  committed
  95df2d1

  Copy full SHA for 95df2d1

• fix: setter assignment returns rhs value

  Show description for 590124e
  

  mkubilayk

  authored and

  dragomirtitian

  committed
  590124e

  Copy full SHA for 590124e

• add a test for setter assignment return value

  Show description for 219ea83
  

  mkubilayk

  authored and

  dragomirtitian

  committed
  219ea83

  Copy full SHA for 219ea83

• fix: handle duplicate accessors

  Show description for 25da8ca
  

  mkubilayk

  authored and

  dragomirtitian

  committed
  25da8ca

  Copy full SHA for 25da8ca

• add tests for duplicate accessors

  Show description for a2228be
  

  mkubilayk

  authored and

  dragomirtitian

  committed
  a2228be

  Copy full SHA for a2228be

• docs: add missing parameter docs

  Show description for ff4f737
  

  mkubilayk

  authored and

  dragomirtitian

  committed
  ff4f737

  Copy full SHA for ff4f737

• Fixed failing test.

  dragomirtitian

  committed
  704727c

  Copy full SHA for 704727c

Commits on Feb 17, 2021

• baseline-accept: ordering changes

  Show description for 73925dc
  mkubilayk

  committed
  73925dc

  Copy full SHA for 73925dc

• fix: attach weakSetName to property declaration

  Show description for 67fd38d
  mkubilayk

  committed
  67fd38d

  Copy full SHA for 67fd38d

• add a test for nested private methods

  Show description for 45c2a41
  mkubilayk

  committed
  45c2a41

  Copy full SHA for 45c2a41

• add a test with any

  Show description for 356b91d
  mkubilayk

  committed
  356b91d

  Copy full SHA for 356b91d

Commits on Feb 18, 2021

• Merge pull request #51 from bloomberg/fix/nested-private-methods

  Show description for b391464
  dragomirtitian

  authored
  b391464

  Copy full SHA for b391464

• Added support for static private fields accessors and methods.

  dragomirtitian

  committed
  5ebb3d6

  Copy full SHA for 5ebb3d6

• Added error message for private identifiers used with static decorators. There is no spec to go with this behavior as of yet.

  dragomirtitian

  committed
  7006c09

  Copy full SHA for 7006c09

• Fixed emit static bug that used private names outside of classes for initialization in esnext. Fixed issue where nested privates produce incorrect brand check.

  dragomirtitian

  committed
  b876613

  Copy full SHA for b876613

• Added tests for private static fields methods and accessors.

  dragomirtitian

  committed
  31a8c00

  Copy full SHA for 31a8c00

Commits on Feb 19, 2021

• Merge remote-tracking branch 'remotes/origin/master' into es-private-methods-and-accessors

  dragomirtitian

  committed
  9219e99

  Copy full SHA for 9219e99

• Merge remote-tracking branch 'remotes/bloomberg/es-private-methods-and-accessors' into es-private-static-fields-methods-and-accessors

  dragomirtitian

  committed
  5a27a32

  Copy full SHA for 5a27a32

• Fixed error messages and tests after merge.

  dragomirtitian

  committed
  964fc27

  Copy full SHA for 964fc27

• Merge branch 'es-private-methods-and-accessors' into es-private-static-fields-methods-and-accessors

  dragomirtitian

  committed
  d2ab6fc

  Copy full SHA for d2ab6fc

• Accept new baseline.

  dragomirtitian

  committed
  23f6c67

  Copy full SHA for 23f6c67

• Improved duplicate identifier checks for static private class elements.

  dragomirtitian

  committed
  374e6f3

  Copy full SHA for 374e6f3

Commits on Feb 23, 2021

• Added error when using initializers with private static fields when useDefineForClassFields is not specified and target is esnext.

  dragomirtitian

  committed
  62b4f2f

  Copy full SHA for 62b4f2f

Commits on Feb 24, 2021

• Fixed code review issues.

  dragomirtitian

  committed
  b2a692d

  Copy full SHA for b2a692d

• Removed semantically wrong emit on useDefineForClassFields:true with target:esnext

  dragomirtitian

  committed
  363041e

  Copy full SHA for 363041e

Commits on Feb 25, 2021

• Changed emit for uninitialized private static fields.

  dragomirtitian

  committed
  64757e0

  Copy full SHA for 64757e0

• Added runtime error in helper if a static private field is accessed before it was declared.

  dragomirtitian

  committed
  68a7f80

  Copy full SHA for 68a7f80

• Fixed code review comments for private identifier static class elements.

  dragomirtitian

  committed
  7e7b0b1

  Copy full SHA for 7e7b0b1

Commits on Mar 1, 2021

• add debug.assertNever for unknown node type (#53)

  mkubilayk

  authored
  30c7f69

  Copy full SHA for 30c7f69

• Merge remote-tracking branch 'upstream/master' into es-private-methods-and-accessors

  mkubilayk

  committed
  c924058

  Copy full SHA for c924058

Commits on Mar 2, 2021

• Merge remote-tracking branch 'upstream/master' into es-private-methods-and-accessors

  mkubilayk

  committed
  e65116f

  Copy full SHA for e65116f

Commits on Mar 3, 2021

• Fixed code review issues.

  dragomirtitian

  committed
  4748c87

  Copy full SHA for 4748c87

• Merge branch 'es-private-methods-and-accessors' into es-private-static-fields-methods-and-accessors

  dragomirtitian

  committed
  09a5aae

  Copy full SHA for 09a5aae

• Fixed code review issues for private class elements.

  dragomirtitian

  committed
  497e47f

  Copy full SHA for 497e47f

Commits on Mar 8, 2021

• Fixes class shadowing when checking access to a private static class element.

  dragomirtitian

  committed
  294cc48

  Copy full SHA for 294cc48

• Merge remote-tracking branch 'remotes/origin/master' into es-private-static-fields-methods-and-accessors

  dragomirtitian

  committed
  027bdb3

  Copy full SHA for 027bdb3

Commits on Mar 17, 2021

• Merge remote-tracking branch 'upstream/master'

  mkubilayk

  committed
  7bbc944

  Copy full SHA for 7bbc944

• fix private methods/accessors in class expr inside a loop

  mkubilayk

  committed
  dd526e7

  Copy full SHA for dd526e7

• collapse switch case

  mkubilayk

  committed
  f6ecfab

  Copy full SHA for f6ecfab

• fix class name

  mkubilayk

  committed
  6c3f661

  Copy full SHA for 6c3f661

• simplify getPrivateMethodsAndAccessors

  mkubilayk

  committed
  ef69c6c

  Copy full SHA for ef69c6c

• remove findPreviousAccessorInfo

  mkubilayk

  committed
  2a646ed

  Copy full SHA for 2a646ed

• lazily create weakSetName identifier

  mkubilayk

  committed
  d8136f7

  Copy full SHA for d8136f7

• Merge remote-tracking branch 'remotes/bloomberg/es-private-static-fields-methods-and-accessors' into es-private-methods-and-accessors

  dragomirtitian

  committed
  fbd749c

  Copy full SHA for fbd749c

• Merge remote-tracking branch 'remotes/bloomberg/es-private-static-fields-methods-and-accessors' into es-private-methods-and-accessors

  

  dragomirtitian

  authored and

  mkubilayk

  committed
  f96eafe

  Copy full SHA for f96eafe

Commits on Mar 18, 2021

• Merge branch 'es-private-methods-and-accessors' of https://github.com/bloomberg/TypeScript into es-private-methods-and-accessors

  dragomirtitian

  committed
  2de8a43

  Copy full SHA for 2de8a43

• do not allocate a node if not needed in visitMehodDeclaration (#55)

  mkubilayk

  authored
  7490a36

  Copy full SHA for 7490a36

Commits on Mar 22, 2021

• Removed all the emit helpers for private identifier methods accessors and modified the existing helpers for get and set fields to do the same job.

  

  dragomirtitian

  authored and

  mkubilayk

  committed
  c273258

  Copy full SHA for c273258

• Simplified emit for private identifier class elements.

  

  dragomirtitian

  authored and

  mkubilayk

  committed
  1addbb3

  Copy full SHA for 1addbb3

• do not clone the receiver (#57)

  mkubilayk

  committed
  c461b92

  Copy full SHA for c461b92

• leave bad code in for #constructor and duplicate private names (#58)

  mkubilayk

  committed
  a61fd5f

  Copy full SHA for a61fd5f

• Added check for WeakSet collision.

  

  dragomirtitian

  authored and

  mkubilayk

  committed
  89f746a

  Copy full SHA for 89f746a

• Added error for using a set only accessor.

  dragomirtitian

  committed
  ff24636

  Copy full SHA for ff24636

• Merge pull request #61 from bloomberg/es-private-methods-and-accessors-get-error

  Show description for a60e429
  dragomirtitian

  authored
  a60e429

  Copy full SHA for a60e429

Commits on Mar 23, 2021

• update keyof tests and ?? (#62)

  Show description for f5816ab
  mkubilayk

  authored
  f5816ab

  Copy full SHA for f5816ab

• fix emit helpers comments

  mkubilayk

  committed
  3b62d3c

  Copy full SHA for 3b62d3c

• produce an error if private field helpers are not up to date

  mkubilayk

  committed
  7d8a2b9

  Copy full SHA for 7d8a2b9

• add tests

  mkubilayk

  committed
  d0d2055

  Copy full SHA for d0d2055

• fix setter-only compound assignment

  mkubilayk

  committed
  93a7ca3

  Copy full SHA for 93a7ca3

• Merge pull request #63 from bloomberg/helper-parameter-count

  Show description for 6da2cdd
  mkubilayk

  authored
  6da2cdd

  Copy full SHA for 6da2cdd

• fix tests

  mkubilayk

  committed
  30805b7

  Copy full SHA for 30805b7

Commits on Mar 24, 2021

• fix duplicated trailing comments (#64)

  mkubilayk

  authored
  8d77a8e

  Copy full SHA for 8d77a8e

• clear receiver pos and setTextRange on helper calls

  mkubilayk

  committed
  8078ae0

  Copy full SHA for 8078ae0