Skip to content

typeof on a well-known symbol in a computed property name has a poor error #42530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

typeof on a well-known symbol in a computed property name has a poor error #42530

wants to merge 4 commits into from

Conversation

jonhue
Copy link
Contributor

@jonhue jonhue commented Jan 28, 2021

Fixes #42523

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jan 28, 2021
@jonhue jonhue mentioned this pull request Jan 28, 2021
Closed
DanielRosenwasser
DanielRosenwasser requested changes Jan 28, 2021
View reviewed changes
Copy link
Member

@DanielRosenwasser DanielRosenwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @jonhue! However, since I filed that issue yesterday, I've realized that maybe #24738 is a better direction, where the type-checker will automatically promote well-known symbols to being unique. If we merge this in, we may have to back-out this change afterwards. 😬

@jonhue
Copy link
Contributor Author

jonhue commented Jan 29, 2021

No worries @DanielRosenwasser! That stuff happens 😄

There is still one open question (#42530 (comment)) concerning how to get the text represented by a node.
Happy to close this or follow-up on this depending on what you think is the best idea here!

@DanielRosenwasser
Copy link
Member

I think we have something like tryGetPropertyAccessOrIdentifierToString you can use in the future.

@jonhue
Copy link
Contributor Author

jonhue commented Feb 1, 2021

@DanielRosenwasser are you able to see why the Travis tests are failing? It looks like all other tests are successful 🤔

@DanielRosenwasser
Copy link
Member

Closing this based on the other PR. We ripped Travis out because of failing tests btw.

@jonhue jonhue deleted the fix-42523 branch February 3, 2021 05:36
@jonhue jonhue restored the fix-42523 branch March 7, 2021 08:28
@jonhue jonhue deleted the fix-42523 branch March 7, 2021 08:28
@jonhue jonhue restored the fix-42523 branch March 7, 2021 08:28
@jonhue jonhue deleted the fix-42523 branch March 7, 2021 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRosenwasser DanielRosenwasser Awaiting requested review from DanielRosenwasser

Assignees
No one assigned
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

typeof on a well-known symbol in a computed property name has a poor error
3 participants
@jonhue @DanielRosenwasser @typescript-bot