Skip to content

Make object literal properties new identifier locations when not contextually typed #42612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 3, 2021

Conversation

andrewbranch
Copy link
Member

@andrewbranch andrewbranch commented Feb 2, 2021

Fixes #42595

Kapture 2021-02-02 at 10 54 46

@typescript-bot typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Feb 2, 2021
@andrewbranch
Copy link
Member Author

@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 2, 2021

Heya @andrewbranch, I've started to run the tarball bundle task on this PR at 581ad93. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 2, 2021

Hey @andrewbranch, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/94734/artifacts?artifactName=tgz&fileId=9BC4F63633CFF0695B4863FD92134399535943BD860CDE9B66D1BF268DBF601702&fileName=/typescript-4.2.0-insiders.20210202.tgz"
    }
}

and then running npm install.


There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@4.2.0-pr-42612-2".;

Copy link
Member

@DanielRosenwasser DanielRosenwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test for comma tokens.

@andrewbranch andrewbranch merged commit 96cc9b9 into microsoft:master Feb 3, 2021
@andrewbranch andrewbranch deleted the bug/42595 branch February 3, 2021 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Methods are not new identifier definition locations
4 participants