Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix preserveSourceNewlines sibling node comparison (fixes extra newlines in organize imports) #42630
Fix preserveSourceNewlines sibling node comparison (fixes extra newlines in organize imports) #42630
Changes from 35 commits
cb05c28
2f4d4c1
b94544a
60d63dd
3d45ac0
7dda7e3
24f0d6b
a9a8cbb
9e42a69
12cc980
a43ec41
3a6a36a
202873a
78ea60a
2b0578d
e7c832a
62604bc
4d807de
dda079d
9c121aa
8777dc7
f1aa0f9
e4e4cf2
dd79363
2e93e31
c709f17
67ad6b4
5215977
7cdbdb9
b51345e
662ee6c
aaf353e
c40b579
07930c2
a368a48
de698f9
77b1902
bcbec24
af14aef
a0bf137
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These JS baseline changes are reverting back to their original state pre-#36688. That PR was never really meant to change JS emit, but the couple changes that did occur seemed ok so we went with it. Since
siblingNodePositionsAreComparable
might do a little more work than what’s currently happening in master, I reverted the codepath that non-codefix/refactor emit takes back to the way it originally was.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
siblingNodePositionsAreComparable
is now quite cheap, but I think it still makes sense to keep it out of JS emit for now.