Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce void | undefined only in conjunction with subtype reduction #42846

Merged
merged 3 commits into from
Feb 18, 2021
Merged

Reduce void | undefined only in conjunction with subtype reduction #42846

merged 3 commits into from
Feb 18, 2021

Conversation

ahejlsberg
Copy link
Member

Fixes #42786.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Feb 17, 2021
@DanielRosenwasser DanielRosenwasser mentioned this pull request Feb 17, 2021
Closed
@ahejlsberg ahejlsberg merged commit 412ecbc into master Feb 18, 2021
@ahejlsberg ahejlsberg deleted the fix42786 branch February 18, 2021 00:48
@ahejlsberg
Copy link
Member Author

@DanielRosenwasser Will you cherry pick this one into 4.2?

@DanielRosenwasser
Copy link
Member

@typescript-bot cherry-pick this to release-4.2

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 18, 2021 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-4.2 on this PR at e7b6601. You can monitor the build here.

@typescript-bot typescript-bot mentioned this pull request Feb 18, 2021
Merged
@typescript-bot
Copy link
Collaborator

Hey @DanielRosenwasser, I've opened #42852 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Feb 18, 2021
@ahejlsberg @typescript-bot
Cherry-pick PR microsoft#42846 into release-4.2
8ed48d8 
Component commits:
0edae12 Reduce void | undefined only in conjunction with subtype reduction

6b487a6 Accept new baselines

e7b6601 Add regression test
DanielRosenwasser pushed a commit that referenced this pull request Feb 18, 2021
@ahejlsberg
Cherry-pick PR #42846 into release-4.2 (#42852)
57ba6dd 
Component commits:
0edae12 Reduce void | undefined only in conjunction with subtype reduction

6b487a6 Accept new baselines

e7b6601 Add regression test

Co-authored-by: Anders Hejlsberg <andersh@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanCavanaugh RyanCavanaugh RyanCavanaugh approved these changes

@DanielRosenwasser DanielRosenwasser DanielRosenwasser approved these changes

Assignees

@ahejlsberg ahejlsberg

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inference to unions containing void behave differently from 4.2 on
4 participants
@ahejlsberg @DanielRosenwasser @typescript-bot @RyanCavanaugh