Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static class block support #43308

Closed
wants to merge 81 commits into from
Closed

Static class block support #43308

wants to merge 81 commits into from

Conversation

Kingwl
Copy link
Contributor

@Kingwl Kingwl commented Mar 19, 2021

Closes #43092
Fixes #43012

dragomirtitian and others added 30 commits February 3, 2021 18:44
@dragomirtitian
Added support for private identifier methods.
e3a3fb8
@dragomirtitian
Added tests for private methods.
4ab27a2
@dragomirtitian
Added check to only not allow private name method signatures in anyth…
6977b9f 
…ing except classes.

Changes objects literal checking to not bail on first private name found in object literal.
@dragomirtitian
Added private accessors tests
bc8c07e
@mkubilayk @dragomirtitian
Transform private methods
2760ed8 
Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com>
@mkubilayk @dragomirtitian
Rename shouldTransformPrivateFields
04af85d 
Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com>
@mkubilayk @dragomirtitian
Accept baseline
f048d72 
Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com>
@mkubilayk @dragomirtitian
Use a single WeakSet for brand-check
f8cfb81 
Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com>
@mkubilayk @dragomirtitian
Accept baseline
4aa4c3b 
Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com>
@mkubilayk @dragomirtitian
Add a test for using private methods in static field initializers
0ac1271 
Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com>
@mkubilayk @dragomirtitian
Add breaking checker test
7da5bd9 
Private methods inside class expressions should not error.

Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com>
@mkubilayk @dragomirtitian
Add to instances once per-instance
e133f60 
Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com>
@mkubilayk @dragomirtitian
Accept baseline
aa5dd8a 
Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com>
@mkubilayk @dragomirtitian
fix: evaluate receiver and rhs expressions before throwing on readonl…
a3889a7 
…y assignment

Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com>
@mkubilayk @dragomirtitian
Add a test for evaluating rhs before readonly assignment
8952caa 
Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com>
@mkubilayk @dragomirtitian
Transpile private accessors
dee87bb 
Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com>
@mkubilayk @dragomirtitian
Accept baseline
aec7e9b 
Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com>
@mkubilayk @dragomirtitian
fix: handle readonly/writeonly accessors
f3bbf0f 
Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com>
@mkubilayk @dragomirtitian
accept baseline
a1b59cd 
Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com>
@mkubilayk @dragomirtitian
add a test for private setter without a getter
6b74498 
Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com>
@mkubilayk @dragomirtitian
fix: getAllUnscopedEmitHelpers
d51f6cd 
Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com>
@mkubilayk @dragomirtitian
fix: better handling of duplicate names
c175770 
Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com>
@dragomirtitian
Fixed wrong error message for private methods in class expressions.
4301af5
@mkubilayk @dragomirtitian
change error message
3a056b2 
Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com>
@mkubilayk @dragomirtitian
add a test for async private methods with a higher target
95df2d1 
Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com>
@mkubilayk @dragomirtitian
fix: setter assignment returns rhs value
590124e 
Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com>
@mkubilayk @dragomirtitian
add a test for setter assignment return value
219ea83 
Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com>
@mkubilayk @dragomirtitian
fix: handle duplicate accessors
25da8ca 
Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com>
@mkubilayk @dragomirtitian
add tests for duplicate accessors
a2228be 
Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com>
@mkubilayk @dragomirtitian
docs: add missing parameter docs
ff4f737 
Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com>
mkubilayk and others added 14 commits March 17, 2021 12:26
@mkubilayk
fix class name
6c3f661
@mkubilayk
simplify getPrivateMethodsAndAccessors
ef69c6c
@mkubilayk
remove findPreviousAccessorInfo
2a646ed
@mkubilayk
lazily create weakSetName identifier
d8136f7
@dragomirtitian
Merge remote-tracking branch 'remotes/bloomberg/es-private-static-fie…
fbd749c 
…lds-methods-and-accessors' into es-private-methods-and-accessors
@dragomirtitian @mkubilayk
Merge remote-tracking branch 'remotes/bloomberg/es-private-static-fie…
f96eafe 
…lds-methods-and-accessors' into es-private-methods-and-accessors
@dragomirtitian
Merge branch 'es-private-methods-and-accessors' of https://github.com…
2de8a43 
…/bloomberg/TypeScript into es-private-methods-and-accessors
@dragomirtitian
Removed all the emit helpers for private identifier methods accessors…
5a2f195 
… and modified the existing helpers for get and set fields to do the same job.
@mkubilayk
do not allocate a node if not needed in visitMehodDeclaration (micros…
7490a36 
…oft#55)
@dragomirtitian
Simplified emit for private identifier class elements.
a3fdc4b
@dragomirtitian
Merge pull request microsoft#56 from bloomberg/es-private-methods-and…
668245b 
…-accessors-simplify-emit

Es private methods and accessors simplify emit
@mkubilayk
do not clone the receiver (microsoft#57)
55a7097
@Kingwl
Class static block (#9)
7463517 
* Add types factory and parser

* Add some case

* Make class static block as a container

* Update cases

* Add visitor

* Add emitter and more compile target

* Check boundary of break and continue
@Kingwl
Add basic transformer
820b1d2
@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Mar 19, 2021
@Kingwl Kingwl marked this pull request as draft March 19, 2021 07:45
@Kingwl Kingwl mentioned this pull request Mar 19, 2021
Closed
11 tasks
@Kingwl
Copy link
Contributor Author

Kingwl commented Mar 19, 2021

Hi @dragomirtitian @mkubilayk !

Please take a look If you are Interested in this. Thanks!

@rbuckton rbuckton mentioned this pull request Mar 19, 2021
Merged
3 tasks
@orta
Copy link
Contributor

orta commented Mar 23, 2021

@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 23, 2021 •
edited
Loading

Heya @orta, I've started to run the tarball bundle task on this PR at 11a2934. You can monitor the build here.

@Kingwl
Copy link
Contributor Author

Kingwl commented Mar 23, 2021

Hoops. Seems something broken.

@orta
Copy link
Contributor

orta commented Mar 23, 2021

Interesting, you just updated the baselines which seems to be what the failing error message is about

@Kingwl Kingwl mentioned this pull request Mar 25, 2021
Merged
@Kingwl Kingwl closed this Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rbuckton rbuckton

Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposal class static block
6 participants
@Kingwl @orta @typescript-bot @rbuckton @dragomirtitian @mkubilayk