Don't use _fs.realpathSync.native on windows, a semi-revert of #41292 #43348
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch hotfix for #43105 reverting #41292
Roughly:
realpathSync.native
returns uppercased drive labels on Windows which differs fromrealpathSync
. without the native suffix.This triggers at least one or two bugs further down the line (e.g. #43342 ) and doing a lot of symlink work assuming maybe
c:/x/y/z.ts
is a symlink toC:/x/y/z.ts
, that code crashes because it assumes you'd never pass matching paths to the symlink guessing codepaths.4.3 can get a more thorough fix which ideally should keep
realpathSync.native