Report error if class uses extended type before its declaration #4343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,15 @@ | |||
| var c = class A extends B { // error | |||
| } | |||
There was a problem hiding this comment.
i would also add a test with an expression in an extend clause, class A extends foo(0)<string> {}
and one for module aliases
import d from "mod";
class B extends d { // no error here
}… report error Fixes #4244
|
I am still working on reporting error if alias is declared before it is referencing entity(internal alias only) |
| let file1 = getSourceFileOfNode(node1); | ||
| let file2 = getSourceFileOfNode(node2); | ||
| if (file1 === file2) { | ||
| return node1.pos <= node2.pos; | ||
| return node1.pos <= node2.pos || !isInSameLexicalScope(); |
There was a problem hiding this comment.
Why are they allowed to be in different lexical scopes?
| @@ -393,9 +398,28 @@ namespace ts { | |||
| } | |||
|
|
|||
| let sourceFiles = host.getSourceFiles(); | |||
| return sourceFiles.indexOf(file1) <= sourceFiles.indexOf(file2); | |||
| } | |||
| return sourceFiles.indexOf(referenceDeclarationFile) <= sourceFiles.indexOf(locationNodeFile) || !isInSameLexicalScope(); | |||
There was a problem hiding this comment.
use ts.indexOf instead of array.prototype.indexof
| return; | ||
| } | ||
|
|
||
| let meaning = node.parent.kind === SyntaxKind.QualifiedName || node.parent.kind === SyntaxKind.PropertyAccessExpression? |
There was a problem hiding this comment.
Fix spacing at the end of the line
| let file2 = getSourceFileOfNode(node2); | ||
| if (file1 === file2) { | ||
| return node1.pos <= node2.pos; | ||
| function isDefinedBefore(referenceDeclaration: Node, locationNode: Node): boolean { |
|
This PR is superseded by #8636 which has been successfully merged, right? |
|
closing in favor of #8636 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4341