Skip to content

Conversation

@sheetalkamat
Copy link
Member

Fixes #4341

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would also add a test with an expression in an extend clause, class A extends foo(0)<string> {}
and one for module aliases

import d from "mod"; 
class B extends d { // no error here
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added this

@sheetalkamat
Copy link
Member Author

I am still working on reporting error if alias is declared before it is referencing entity(internal alias only)
Update: its done now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are they allowed to be in different lexical scopes?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use ts.indexOf instead of array.prototype.indexof

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix spacing at the end of the line

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isDefinedBeforeOrAt

@weswigham
Copy link
Member

This PR is superseded by #8636 which has been successfully merged, right?

@mhegazy
Copy link
Contributor

mhegazy commented Sep 13, 2016

closing in favor of #8636

@mhegazy mhegazy closed this Sep 13, 2016
@mhegazy mhegazy deleted the baseClassDeclarationOrder branch September 13, 2016 22:11
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants