Allow intersected numbers in arithmetics & element access #4373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Return true if type has the given flags, or is a union or intersection type composed of types that all have those flags. | ||
| // Return true if type has the given flags, | ||
| // is a union type composed of types that all have those flags, | ||
| // or an intersection type that contains (at least) one type that has those flags. | ||
| function allConstituentTypesHaveKind(type: Type, kind: TypeFlags): boolean { |
There was a problem hiding this comment.
I think that the name of this function is now misleading.
There was a problem hiding this comment.
Agree about that, do you have a better name? Maybe just typeHasKind?
|
Closing since #4639 proposes a better solution |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4372