Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow override as parameter property #43831

Merged
merged 6 commits into from
Apr 28, 2021
Merged

Allow override as parameter property #43831

merged 6 commits into from
Apr 28, 2021

Conversation

andrewbranch
Copy link
Member

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Apr 26, 2021
DanielRosenwasser
DanielRosenwasser requested changes Apr 26, 2021
View reviewed changes
Copy link
Member

@DanielRosenwasser DanielRosenwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the same sort of comment that's around the readonly modifier, then update checkGrammarModifiers

@Kingwl
Copy link
Contributor

Kingwl commented Apr 28, 2021

Thanks!

@DanielRosenwasser DanielRosenwasser mentioned this pull request Apr 28, 2021
Closed
@andrewbranch andrewbranch merged commit 791c747 into microsoft:master Apr 28, 2021
@andrewbranch andrewbranch deleted the feature/override-parameter-property branch April 28, 2021 23:41
This was referenced May 9, 2021
Merged
Merged
This was referenced Jun 6, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajafff ajafff ajafff left review comments

@DanielRosenwasser DanielRosenwasser DanielRosenwasser requested changes

@sheetalkamat sheetalkamat sheetalkamat approved these changes

Assignees

@andrewbranch andrewbranch

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@andrewbranch @Kingwl @DanielRosenwasser @sheetalkamat @ajafff @typescript-bot