-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add writeFile and customTransformers to build and buildReferences #43984
Conversation
Ping i would like to get this in for 4.3.1 |
Tremendous! |
Thanks so much @sheetalkamat ! |
@sheetalkamat I tried to use it and it is finally not sufficient for ts-loader in watch mode When we build in watch mode, we use createSolutionBuilderWithWatch and the rebuild is initiated by the SolutionBuilderWorker by calling buildNextInvalidatedProject which then calls "done" on the invalidated project without the customTransformers. Would it be possible to add the same parameter "getCustomTransformers?: (project: string) => CustomTransformers" Also, last year you optimised the project references build in ts-loader but I am not sure to understand how it works. in instances.ts (https://github.com/TypeStrong/ts-loader/blob/main/src/instances.ts) line 483 function buildSolutionReferences
Within buildReferences I don't find any 'build' call... but when I debug the 'timeout functions' I find the buildNextInvalidatedProject calls (file https://github.com/TypeStrong/ts-loader/blob/main/src/servicesHost.ts line 894) If we add getCustomTransformers parameter to createSolutionBuilderWithWatch will it be sufficient or do we have to pass it to the solutionBuilderHost in some way ? Thanks. Also, should I create a ticket ? ping @johnnyreilly |
I'd just use the discussion here for now - it has the context. |
…tting. This allows not having to specify the transformers during normal watch scneario Builds on top of #43984
…tting. This allows not having to specify the transformers during normal watch scneario Builds on top of #43984
This one should help with TypeStrong/ts-loader#1274