Skip to content

Add Intl.DisplayNames types #44022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

TimvdLippe
Copy link
Contributor

The TC39 proposal (https://github.com/tc39/proposal-intl-displaynames)
reached stage 4 in September 2020.

Fixes #41338

Please verify that:

  • There is an associated issue in the Backlog milestone (required)
  • Code is up-to-date with the master branch
  • You've successfully run gulp runtests locally
  • There are new or updated unit tests validating the change

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label May 10, 2021
@sandersn sandersn requested review from orta and rbuckton May 18, 2021 23:38
@sandersn
Copy link
Member

@DanielRosenwasser you previously commented on #40786 saying that Intl is not part of the main TC39 spec, so in #40709 we added a property to NumberFormatOptions to ES5 instead of ES2020. Where does Intl.DisplayNames fall? How do I tell so I can review these PRs myself?

@TimvdLippe
Copy link
Contributor Author

@DanielRosenwasser Friendly ping for the above question 😄

@orta
Copy link
Contributor

orta commented Jun 29, 2021

In the meantime, a strange request but I'd prefer it to have less jsdoc information. We ship all of these dts files to consumers on npm and web which means we need to try keep the filesize somewhat reasonable and the dts files account for the many mbs which people have to download before anything can happen.

Any chance you can drop the @param info to just oneliners?

@TimvdLippe
Copy link
Contributor Author

@orta I would absolutely love to, as it was an absolute pain to get all the formatting correct. However, a lot of the other types do have the JSDoc there. Therefore, does it make sense to first drop all of these and then we update existing PRs to also drop the information?

@TimvdLippe
Copy link
Contributor Author

@DanielRosenwasser We would like to remove the local patch we have in DevTools. Could you please provide a status update for what we should do with shipping these internationalization type APIs?

orta added a commit to orta/TypeScript that referenced this pull request Aug 30, 2021
@orta orta mentioned this pull request Aug 30, 2021
orta pushed a commit that referenced this pull request Sep 8, 2021
* Import of Intl.Locale from #39664

* Handle updating es2020.intl and add es2021 for new DateTimeFormatOptions options - re: #39664

* Extends DateTimeFormatOptions for new Intl APIs - re: #45420

* Handle migrating Intl.NumberFormat.formatToParts to es2018 (keeping esnext.intl around)

* Adds Intl.DisplayNames to es2020 - re: #44022

* Remove attributes added in es2021 from es2020 - re: #42944

* Add a reference to es2021 in the command line parser

* Adds some docs about the lib files

* Baselines

* Allow undefined in Intl inputs to allow for ergonomic usage of exactOptionalPropertyTypes - see #45652

* Adds some tests covering the APIs

* Apply suggestions from code review

Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>

* Handle PR feedback

* More review improvements

Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
@orta
Copy link
Contributor

orta commented Sep 8, 2021

Thanks for the PR, I've merged these changes in with a big overhaul of all Intl APIs for 4.5 - #45647

@orta orta closed this Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Intl.DisplayNames missing
4 participants