Skip to content

fix: internal createSignature declaration could be undefined #44109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 24, 2021
Merged

fix: internal createSignature declaration could be undefined #44109

merged 1 commit into from
May 24, 2021

Conversation

ZYSzys
Copy link
Contributor

@ZYSzys ZYSzys commented May 16, 2021 •
edited
Loading

Part of #18217.

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label May 16, 2021
@typescript-bot
Copy link
Collaborator

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

@sandersn sandersn added the Housekeeping Housekeeping PRs label May 24, 2021
sandersn
sandersn approved these changes May 24, 2021
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to believe this is only used in one place and it was still incorrect. I guess I wrote this just before we turned strictNullChecks on.

@sandersn sandersn merged commit eb7c1ad into microsoft:master May 24, 2021
@ZYSzys ZYSzys deleted the types-createSignature branch May 28, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersn sandersn sandersn approved these changes

Assignees
No one assigned
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug Housekeeping Housekeeping PRs
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZYSzys @typescript-bot @sandersn