-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New command line help developer experience. #44157
Conversation
Still to do things:
|
Issues:
|
5f3ac3e
to
399e0a0
Compare
Very cool work! (output)
|
…TypeScript into refactor-help-output
There is a strange lint error. I feel it is not related to this PR. edit: weird! The output of azure and github action tells out of memory. Need some time to find out the reason. |
Great work! I'll tweak this a bunch and see if I can get the linter not bailing too |
Confirmed with some logs in the test that there an infinite loop, will look at this tomorrow |
Finally, I moved into new house and have spared time.... And thanks a lot to @orta 's analytics, it is really helpful. The related code is in host.ts
It is easy to test, we could create two files:
tmp2.js (child process)
The output is |
Auh, it seems a little strange for the test case of
What should we do? I feel we need to delete this case, the correspond file is |
I wonder if we can hardcode the width in the test somehow? |
Good suggestion! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed only API and not actual functionality and that looks good now.
I've done some work on getting this ready locally, it's close - I've got to set up all the localization etc. Hopefully should be ready tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, this is looking good to me. I'll give it till next week to give some other compiler folks to take a look over the changes but thanks a lot @ShuiRuTian! Great work.
Alright, let's go. |
Fixes #44074