Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(28491): add QF to declare missing properties #44576

Merged
merged 1 commit into from
Jun 17, 2021
Merged

feat(28491): add QF to declare missing properties #44576

merged 1 commit into from
Jun 17, 2021

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #28491

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jun 14, 2021
@a-tarasyuk a-tarasyuk marked this pull request as ready for review June 14, 2021 16:31
@typescript-bot
Copy link
Collaborator

The TypeScript team hasn't accepted the linked issue #28491. If you can get it accepted, this PR will have a better chance of being reviewed.

DanielRosenwasser
DanielRosenwasser requested changes Jun 15, 2021
View reviewed changes
Copy link
Member

@DanielRosenwasser DanielRosenwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want a bit more test coverage.

tests/cases/fourslash/codeFixAddMissingProperties8.ts Outdated Show resolved Hide resolved
src/services/codefixes/fixAddMissingMember.ts Show resolved Hide resolved
tests/cases/fourslash/codeFixAddMissingProperties1.ts Outdated Show resolved Hide resolved
@andrewbranch
Copy link
Member

@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 17, 2021 •
edited
Loading

Heya @andrewbranch, I've started to run the tarball bundle task on this PR at 5896e3b. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 17, 2021 •
edited
Loading

Hey @andrewbranch, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/105173/artifacts?artifactName=tgz&fileId=C607D22BDB832E857D96A8EDE1088CB00C7D84B8C315BAC7837C2B5B7FCDFACA02&fileName=/typescript-4.4.0-insiders.20210617.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@4.4.0-pr-44576-3".;

@andrewbranch
Copy link
Member

No playground link @typescript-bot? ☹️

@a-tarasyuk a-tarasyuk requested a review from andrewbranch June 17, 2021 17:17
andrewbranch
andrewbranch approved these changes Jun 17, 2021
View reviewed changes
Copy link
Member

@andrewbranch andrewbranch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DanielRosenwasser DanielRosenwasser merged commit eee34d5 into microsoft:main Jun 17, 2021
@a-tarasyuk a-tarasyuk mentioned this pull request Jun 28, 2021
Merged
@a-tarasyuk a-tarasyuk mentioned this pull request Jul 23, 2021
Closed
5 tasks
This was referenced Oct 17, 2021
Open
Closed
@hpx7 hpx7 mentioned this pull request Feb 5, 2022
Closed
@hpx7 hpx7 mentioned this pull request May 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewbranch andrewbranch andrewbranch approved these changes

@DanielRosenwasser DanielRosenwasser DanielRosenwasser approved these changes

@weswigham weswigham Awaiting requested review from weswigham

Assignees
No one assigned
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Declare all missing members quick fix
4 participants
@a-tarasyuk @typescript-bot @andrewbranch @DanielRosenwasser