Sort types for display #44614
Closed
Sort types for display #44614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pushing to a PR for performance testing. This looks extremely slow.
typescript-bot
added
Author: Team
For Milestone Bug
|
@typescript-bot perf test this |
|
Heya @sandersn, I've started to run the perf test suite on this PR at 72a1808. You can monitor the build here. Update: The results are in! |
|
@sandersn Here they are:Comparison Report - main..44614
System
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
a-tarasyuk
reviewed
Jun 16, 2021
| @@ -365,6 +365,93 @@ namespace ts { | |||
|
|
|||
| const argumentsSymbol = createSymbol(SymbolFlags.Property, "arguments" as __String); | |||
| const requireSymbol = createSymbol(SymbolFlags.Property, "require" as __String); | |||
| const fail = (name: string) => () => Debug.fail("Unit kind expected for " + name) | |||
| // boolean, bigint, number, string, symbol [literal], boolean, bigint, number, string, symbol, object, union (recursive?!), ..., unknown, never, null, void, undefined, any | |||
| const ordre: Array<[TypeFlags, (t1: Type, t2: Type) => Comparison]> = [ | |||
There was a problem hiding this comment.
This is a draft, so this is just the name that fell out of my brain and it happened to be in French. (I often use short, intentionally bad names so I'll be forced to change them later.)
|
Do we have declaration emit captured in the perf tests? |
|
@amcasey seemed to think not, so on his recommendation I have been testing by compiling tinymce instead. However, it has around 1000 unions, which may not be enough to detect a worst-case slowdown. Maybe I should find a gnarly DT package, read it, then print it out and see how long printing it takes. |
|
Notes from discussion in our team meeting:
|
|
Well, this was an interesting experiment, but after finishing the sort code, I found the best performance test is our type baselines. I just ran Note that the type baselines are a worst-case test of performance. Lots of projects wouldn't slow down that much, but really big ones with a lot of types generated across modules would resemble the type baselines. |
This was referenced Jun 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pushing to a PR for performance testing. This initial cut looks extremely slow.
Fixes #32224