Skip to content

Make files safe for Windows #44651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 18, 2021
Merged

Make files safe for Windows #44651

merged 4 commits into from
Jun 18, 2021

Conversation

sandersn
Copy link
Member

@sandersn sandersn commented Jun 18, 2021

NTFS is case insensitive and has a 240-character limit on paths. At least, I think Windows still uses NTFS.

  1. make typeofthis tests case-insensitive-safe
  2. shorten too-long paths of test output
    Fixes git clone fails on Windows #44638

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jun 18, 2021
@sandersn sandersn changed the title Make files safe for windows Make files safe for Windows Jun 18, 2021
@sandersn sandersn merged commit 580bb06 into main Jun 18, 2021
@sandersn sandersn deleted the make-files-safe-for-windows branch June 18, 2021 16:08
@Kingwl
Copy link
Contributor

Kingwl commented Jun 25, 2021

Suffering from case-sensitivity issues🤦‍♂️.

@sandersn
Copy link
Member Author

Pretty sure we were suffering from case insensitivity issues. And short filename issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

git clone fails on Windows
4 participants