Consistently ignore attributes with hyphenated names in JSX #44873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
|
|
||
| function isUnhyphenatedJsxName(name: string | __String) { | ||
| return !stringContains(name as string, "-"); | ||
| function isHyphenatedJsxName(name: string | __String) { |
|
You'll need to accept baselines. |
|
|
||
| declare function Yadda(props: Props): JSX.Element; | ||
| ~~~ | ||
| !!! error TS2503: Cannot find namespace 'JSX'. |
There was a problem hiding this comment.
Does this need to be React.JSX.Element?
RyanCavanaugh
approved these changes
Jul 6, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the strange error elaboration behavior seen in #44797. The PR does not introduce validation of attributes with hyphenated names in the presence of index signatures, and attributes with hyphenated names are still ignored in excess property checking.