-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Consistently ignore attributes with hyphenated names in JSX #44873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| tests/cases/compiler/ignoredJsxAttributes.tsx(16,5): error TS2322: Type 'number' is not assignable to type 'string'. | ||
| tests/cases/compiler/ignoredJsxAttributes.tsx(20,11): error TS2741: Property 'foo' is missing in type '{ bar: string; "data-yadda": number; }' but required in type 'Props'. | ||
|
|
||
|
|
||
| ==== tests/cases/compiler/ignoredJsxAttributes.tsx (2 errors) ==== | ||
| /// <reference path="/.lib/react16.d.ts" /> | ||
|
|
||
| // Repro from #44797 | ||
|
|
||
| import * as React from "react"; | ||
|
|
||
| interface Props { | ||
| foo: string; | ||
| [dataProp: string]: string; | ||
| } | ||
|
|
||
| declare function Yadda(props: Props): JSX.Element; | ||
|
|
||
| let props: Props = { | ||
| foo: "", | ||
| "data-yadda": 42, // Error | ||
| ~~~~~~~~~~~~ | ||
| !!! error TS2322: Type 'number' is not assignable to type 'string'. | ||
| !!! related TS6501 tests/cases/compiler/ignoredJsxAttributes.tsx:9:5: The expected type comes from this index signature. | ||
| }; | ||
|
|
||
| let x1 = <Yadda foo="hello" data-yadda={42}/>; | ||
| let x2 = <Yadda bar="hello" data-yadda={42}/>; // Error | ||
| ~~~~~ | ||
| !!! error TS2741: Property 'foo' is missing in type '{ bar: string; "data-yadda": number; }' but required in type 'Props'. | ||
| !!! related TS2728 tests/cases/compiler/ignoredJsxAttributes.tsx:8:5: 'foo' is declared here. | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| //// [ignoredJsxAttributes.tsx] | ||
| /// <reference path="/.lib/react16.d.ts" /> | ||
|
|
||
| // Repro from #44797 | ||
|
|
||
| import * as React from "react"; | ||
|
|
||
| interface Props { | ||
| foo: string; | ||
| [dataProp: string]: string; | ||
| } | ||
|
|
||
| declare function Yadda(props: Props): JSX.Element; | ||
|
|
||
| let props: Props = { | ||
| foo: "", | ||
| "data-yadda": 42, // Error | ||
| }; | ||
|
|
||
| let x1 = <Yadda foo="hello" data-yadda={42}/>; | ||
| let x2 = <Yadda bar="hello" data-yadda={42}/>; // Error | ||
|
|
||
|
|
||
| //// [ignoredJsxAttributes.js] | ||
| "use strict"; | ||
| /// <reference path="react16.d.ts" /> | ||
| exports.__esModule = true; | ||
| // Repro from #44797 | ||
| var React = require("react"); | ||
| var props = { | ||
| foo: "", | ||
| "data-yadda": 42 | ||
| }; | ||
| var x1 = React.createElement(Yadda, { foo: "hello", "data-yadda": 42 }); | ||
| var x2 = React.createElement(Yadda, { bar: "hello", "data-yadda": 42 }); // Error |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| === tests/cases/compiler/ignoredJsxAttributes.tsx === | ||
| /// <reference path="react16.d.ts" /> | ||
|
|
||
| // Repro from #44797 | ||
|
|
||
| import * as React from "react"; | ||
| >React : Symbol(React, Decl(ignoredJsxAttributes.tsx, 4, 6)) | ||
|
|
||
| interface Props { | ||
| >Props : Symbol(Props, Decl(ignoredJsxAttributes.tsx, 4, 31)) | ||
|
|
||
| foo: string; | ||
| >foo : Symbol(Props.foo, Decl(ignoredJsxAttributes.tsx, 6, 17)) | ||
|
|
||
| [dataProp: string]: string; | ||
| >dataProp : Symbol(dataProp, Decl(ignoredJsxAttributes.tsx, 8, 5)) | ||
| } | ||
|
|
||
| declare function Yadda(props: Props): JSX.Element; | ||
| >Yadda : Symbol(Yadda, Decl(ignoredJsxAttributes.tsx, 9, 1)) | ||
| >props : Symbol(props, Decl(ignoredJsxAttributes.tsx, 11, 23)) | ||
| >Props : Symbol(Props, Decl(ignoredJsxAttributes.tsx, 4, 31)) | ||
| >JSX : Symbol(JSX, Decl(react16.d.ts, 2493, 12)) | ||
| >Element : Symbol(JSX.Element, Decl(react16.d.ts, 2494, 23)) | ||
|
|
||
| let props: Props = { | ||
| >props : Symbol(props, Decl(ignoredJsxAttributes.tsx, 13, 3)) | ||
| >Props : Symbol(Props, Decl(ignoredJsxAttributes.tsx, 4, 31)) | ||
|
|
||
| foo: "", | ||
| >foo : Symbol(foo, Decl(ignoredJsxAttributes.tsx, 13, 20)) | ||
|
|
||
| "data-yadda": 42, // Error | ||
| >"data-yadda" : Symbol("data-yadda", Decl(ignoredJsxAttributes.tsx, 14, 12)) | ||
|
|
||
| }; | ||
|
|
||
| let x1 = <Yadda foo="hello" data-yadda={42}/>; | ||
| >x1 : Symbol(x1, Decl(ignoredJsxAttributes.tsx, 18, 3)) | ||
| >Yadda : Symbol(Yadda, Decl(ignoredJsxAttributes.tsx, 9, 1)) | ||
| >foo : Symbol(foo, Decl(ignoredJsxAttributes.tsx, 18, 15)) | ||
| >data-yadda : Symbol(data-yadda, Decl(ignoredJsxAttributes.tsx, 18, 27)) | ||
|
|
||
| let x2 = <Yadda bar="hello" data-yadda={42}/>; // Error | ||
| >x2 : Symbol(x2, Decl(ignoredJsxAttributes.tsx, 19, 3)) | ||
| >Yadda : Symbol(Yadda, Decl(ignoredJsxAttributes.tsx, 9, 1)) | ||
| >bar : Symbol(bar, Decl(ignoredJsxAttributes.tsx, 19, 15)) | ||
| >data-yadda : Symbol(data-yadda, Decl(ignoredJsxAttributes.tsx, 19, 27)) | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| === tests/cases/compiler/ignoredJsxAttributes.tsx === | ||
| /// <reference path="react16.d.ts" /> | ||
|
|
||
| // Repro from #44797 | ||
|
|
||
| import * as React from "react"; | ||
| >React : typeof React | ||
|
|
||
| interface Props { | ||
| foo: string; | ||
| >foo : string | ||
|
|
||
| [dataProp: string]: string; | ||
| >dataProp : string | ||
| } | ||
|
|
||
| declare function Yadda(props: Props): JSX.Element; | ||
| >Yadda : (props: Props) => JSX.Element | ||
| >props : Props | ||
| >JSX : any | ||
|
|
||
| let props: Props = { | ||
| >props : Props | ||
| >{ foo: "", "data-yadda": 42, // Error} : { foo: string; "data-yadda": number; } | ||
|
|
||
| foo: "", | ||
| >foo : string | ||
| >"" : "" | ||
|
|
||
| "data-yadda": 42, // Error | ||
| >"data-yadda" : number | ||
| >42 : 42 | ||
|
|
||
| }; | ||
|
|
||
| let x1 = <Yadda foo="hello" data-yadda={42}/>; | ||
| >x1 : JSX.Element | ||
| ><Yadda foo="hello" data-yadda={42}/> : JSX.Element | ||
| >Yadda : (props: Props) => JSX.Element | ||
| >foo : string | ||
| >data-yadda : number | ||
| >42 : 42 | ||
|
|
||
| let x2 = <Yadda bar="hello" data-yadda={42}/>; // Error | ||
| >x2 : JSX.Element | ||
| ><Yadda bar="hello" data-yadda={42}/> : JSX.Element | ||
| >Yadda : (props: Props) => JSX.Element | ||
| >bar : string | ||
| >data-yadda : number | ||
| >42 : 42 | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| // @strict: true | ||
| // @jsx: react | ||
| /// <reference path="/.lib/react16.d.ts" /> | ||
|
|
||
| // Repro from #44797 | ||
|
|
||
| import * as React from "react"; | ||
|
|
||
| interface Props { | ||
| foo: string; | ||
| [dataProp: string]: string; | ||
| } | ||
|
|
||
| declare function Yadda(props: Props): JSX.Element; | ||
|
|
||
| let props: Props = { | ||
| foo: "", | ||
| "data-yadda": 42, // Error | ||
| }; | ||
|
|
||
| let x1 = <Yadda foo="hello" data-yadda={42}/>; | ||
| let x2 = <Yadda bar="hello" data-yadda={42}/>; // Error |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍