Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close package json watches in watch mode on close #45642

Merged

Conversation

weswigham
Copy link
Member

Fixes #45633

@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Aug 30, 2021
Copy link
Member

@andrewbranch andrewbranch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@weswigham weswigham merged commit f598076 into microsoft:main Aug 30, 2021
@weswigham
Copy link
Member Author

@andrewbranch want this picked into the 4.4 branch?

@andrewbranch
Copy link
Member

Yes please

@weswigham
Copy link
Member Author

@typescript-bot cherrypick this into release-4.4

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 30, 2021

Heya @weswigham, I've started to run the task to cherry-pick this into release-4.4 on this PR at 58e56ed. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

Hey @weswigham, I've opened #45644 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Aug 30, 2021
Component commits:
58e56ed Close package json watches in watch mode on close
andrewbranch pushed a commit that referenced this pull request Aug 30, 2021
Component commits:
58e56ed Close package json watches in watch mode on close

Co-authored-by: Wesley Wigham <t-weswig@microsoft.com>
nathonius added a commit to nathonius/obsidian-trello that referenced this pull request Sep 2, 2021
@sunshineplan
Copy link

@weswigham Any plan for a new release?

nicoleoliveira added a commit to animaliads/animalia-web-components that referenced this pull request Sep 3, 2021
Tem uma issue no typescript porque está travando o build.
microsoft/TypeScript#45642
rollup/rollup#4213
@andrewbranch
Copy link
Member

There will be a patch probably within the next week or two.

anomiex added a commit to Automattic/jetpack that referenced this pull request Sep 7, 2021
enisdenjo added a commit to enisdenjo/graphql-ws that referenced this pull request Sep 8, 2021
enisdenjo added a commit to enisdenjo/graphql-ws that referenced this pull request Sep 8, 2021
enisdenjo added a commit to enisdenjo/graphql-sse that referenced this pull request Sep 8, 2021
nicoleoliveira added a commit to animaliads/animalia-web-components that referenced this pull request Sep 10, 2021
* Novo componente 

* feat: correção da versão do typescript

Tem uma issue no typescript porque está travando o build.
microsoft/TypeScript#45642
rollup/rollup#4213
ppillot added a commit to ppillot/biomsalign that referenced this pull request Jan 1, 2024
This was due to an issue with the typescript version, see microsoft/TypeScript#45642
TS related packages have been upgraded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript 4.4 leaks watchers
4 participants