fix: add corresponding message for override error in js files #45656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stkevintan
force-pushed
the
jsOverrideErrors
branch
from
5e5e4f6 to
4ae986e
Compare
sandersn
requested changes
Sep 3, 2021
Member
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
Looks good, I would just like the word 'leading' removed.
sandersn
approved these changes
Sep 13, 2021
Member
|
@stkevintan Looks like there are 3 lint errors still. Once you fix those I will merge this. |
This was referenced Oct 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45591