Fixes main by updating baselines #46160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orta
commented
Oct 1, 2021
| @@ -525,7 +525,7 @@ namespace Harness.Parallel.Host { | |||
| completeBar(); | |||
| progressBars.disable(); | |||
|
|
|||
| const replayRunner = new Mocha.Runner(new Mocha.Suite(""), /*delay*/ false); | |||
| const replayRunner = new Mocha.Runner(new Mocha.Suite(""), { delay: false }); | |||
There was a problem hiding this comment.
If you do a fresh npm install then you get runtime warnings about this
There was a problem hiding this comment.
This was deprecated officially in mocha 9, released in June, and has had the object form listed as an option for at least a few major versions longer - so the change seems fine to me~
typescript-bot
added
Author: Team
For Uncommitted Bug
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced by #44813 not being fully rebased