Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(46589): Extra ? added to method in method signature completion for optional method #46594

Merged
merged 1 commit into from
Nov 3, 2021
Merged

fix(46589): Extra ? added to method in method signature completion for optional method #46594

merged 1 commit into from
Nov 3, 2021

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #46589

@typescript-bot typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Oct 29, 2021
@a-tarasyuk a-tarasyuk marked this pull request as draft October 29, 2021 21:32
@a-tarasyuk a-tarasyuk force-pushed the fix/46589 branch 2 times, most recently from 6bb521f to b1f2db7 Compare October 29, 2021 21:45
@a-tarasyuk a-tarasyuk marked this pull request as ready for review October 29, 2021 21:46
andrewbranch
andrewbranch approved these changes Oct 29, 2021
View reviewed changes
Copy link
Member

@andrewbranch andrewbranch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟 Thanks!

@andrewbranch andrewbranch requested a review from gabritto October 29, 2021 21:50
gabritto
gabritto requested changes Oct 29, 2021
View reviewed changes
Copy link
Member

@gabritto gabritto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't get rid of optional altogether in the codefix helper function, I think that is why there are tests failing on CI. Left a comment with possible solutions.

src/services/codefixes/helpers.ts Outdated Show resolved Hide resolved
@a-tarasyuk a-tarasyuk requested a review from gabritto October 30, 2021 06:14
@andrewbranch andrewbranch added this to the TypeScript 4.5.2 milestone Nov 1, 2021
gabritto
gabritto requested changes Nov 2, 2021
View reviewed changes
Copy link
Member

@gabritto gabritto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is closer to being what we want, just left a comment for one case left to consider. Thanks :)

src/services/completions.ts Outdated Show resolved Hide resolved
gabritto
gabritto approved these changes Nov 3, 2021
View reviewed changes
Copy link
Member

@gabritto gabritto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment for a typo, but I think other than that we're good to go now. Thanks! ✨

src/services/codefixes/helpers.ts Outdated Show resolved Hide resolved
@andrewbranch
Copy link
Member

@typescript-bot cherry-pick this to release-4.5

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 3, 2021 •
edited
Loading

Heya @andrewbranch, I've started to run the task to cherry-pick this into release-4.5 on this PR at cd33fc8. You can monitor the build here.

@typescript-bot typescript-bot mentioned this pull request Nov 3, 2021
Merged
@typescript-bot
Copy link
Collaborator

Hey @andrewbranch, I've opened #46667 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Nov 3, 2021
@a-tarasyuk @typescript-bot
Cherry-pick PR microsoft#46594 into release-4.5
e68d48b 
Component commits:
cd33fc8 fix(46589): omit ? in method signature completion for optional methods
@andrewbranch andrewbranch merged commit 7264cf7 into microsoft:main Nov 3, 2021
DanielRosenwasser pushed a commit that referenced this pull request Nov 3, 2021
@a-tarasyuk
Cherry-pick PR #46594 into release-4.5 (#46667)
e4a2494 
Component commits:
cd33fc8 fix(46589): omit ? in method signature completion for optional methods

Co-authored-by: Oleksandr T <oleksandr.tarasiuk@outlook.com>
@sync-by-unito sync-by-unito bot mentioned this pull request Dec 1, 2021
Closed
mprobst pushed a commit to mprobst/TypeScript that referenced this pull request Jan 10, 2022
@a-tarasyuk @mprobst
fix(46589): omit ? in method signature completion for optional methods (
b245fc6 
microsoft#46594)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabritto gabritto gabritto approved these changes

@andrewbranch andrewbranch andrewbranch approved these changes

Assignees
No one assigned
Labels
For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Milestone
TypeScript 4.5.2
Development

Successfully merging this pull request may close these issues.

Extra ? added to method in method signature completion for optional method
4 participants
@a-tarasyuk @andrewbranch @typescript-bot @gabritto