Make specifier generation from export map information conditional on module resolution mode #46670
Conversation
…module resolution mode
typescript-bot
added
Author: Team
For Milestone Bug
| } | ||
| if (packageJsonContent.exports) { | ||
| return { moduleFileToTry: path, blockedByExports: true }; | ||
| if (getEmitModuleResolutionKind(options) === ModuleResolutionKind.Node12 || getEmitModuleResolutionKind(options) === ModuleResolutionKind.NodeNext) { |
There was a problem hiding this comment.
I made the whole of the exports map logic conditional - I could just make the failure modes conditional, but then we might make some specifiers that won't roundtrip through declaration emit (because we use an export map that we won't read in when we build the program), so this is probably better.
There was a problem hiding this comment.
Yeah, I think being symmetrical is the right call.
|
@typescript-bot cherry-pick this to release-4.5 |
|
Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into |
|
Hey @DanielRosenwasser, I've opened #46671 for you. |
Component commits: 615a82c Make specifier generation from export map information conditional on module resolution mode
There was a problem hiding this comment.
however
rxjsdoes legitimately have the problem that their types aren't directly visible in their export map, which makes locating a valid specifier for them when export maps are respected rather difficult.
Yeah, my understanding is that it’s fully expected that the layout of RxJS (export map not mentioning types and types in a completely different directory) means it’s basically unusable under the new resolution modes—they either need to move their types to be colocated with their JS or add a "types" condition to their export map.
Component commits: 615a82c Make specifier generation from export map information conditional on module resolution mode Co-authored-by: Wesley Wigham <t-weswig@microsoft.com>
…module resolution mode (microsoft#46670)
Fixes #46659
This fixes the regression on our part in
moduleResolution: node, howeverrxjsdoes legitimately have the problem that their types aren't directly visible in their export map, which makes locating a valid specifier for them when export maps are respected rather difficult.