Completions sorting overhaul #46703
Merged
Completions sorting overhaul #46703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Milestone Bug
andrewbranch
commented
Nov 5, 2021
andrewbranch
changed the title
RyanCavanaugh
approved these changes
Dec 3, 2021
mprobst
pushed a commit
to mprobst/TypeScript
that referenced
this pull request
Jan 10, 2022
* Sort resolved auto-import completions by number of directory separators * Sort completions in services layer * Finish tests * Fix more tests * Respect SortText in completions * Update tests to use `unsorted` assertion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
sortTextin the order we produce—previously, we only sorted alphabetically, relying on the editor to do the additional sorting bysortText. This is not necessary for editors, but makes the order we produce in the language service (and therefore in our fourslash tests) identical to what users would see in an editor.path/posixandpath/win32abovepath#46696 and fixes Sort import completions by distance from current module #41083)unsortedkey forverify.completions, which is likeexactbut doesn’t care about the order.